-
Notifications
You must be signed in to change notification settings - Fork 144
docs: more fixes for afdocs #216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
55a85e1
more fixes for afdocs
jessiemongeon1 89c33f7
Apply suggestions from code review
jessiemongeon1 0ff53dd
Potential fix for pull request finding 'CodeQL / Uncontrolled data us…
jessiemongeon1 b8ce9eb
Potential fix for pull request finding 'CodeQL / Uncontrolled data us…
jessiemongeon1 39c915b
Apply suggestions from code review
jessiemongeon1 1b5592c
Potential fix for pull request finding 'CodeQL / Uncontrolled data us…
jessiemongeon1 c6f0604
Apply suggestions from code review
jessiemongeon1 2dcaad6
Update sidebar.yml
jessiemongeon1 5a0eb8d
Update sidebar.yml
jessiemongeon1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,254 @@ | ||
| /* | ||
| // Copyright (c) Mysten Labs, Inc. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| /** | ||
| * Local server that serves the Docusaurus build with proper headers | ||
| * for markdown files, llms.txt, and content negotiation. | ||
| * | ||
| * Usage: node serve-with-rewrites.js [port] | ||
| */ | ||
|
|
||
| const http = require('http'); | ||
| const fs = require('fs'); | ||
| const path = require('path'); | ||
| const url = require('url'); | ||
|
|
||
| const PORT = process.argv[2] || 3001; | ||
| const BUILD_DIR = path.join(__dirname, 'build'); | ||
| const BUILD_ROOT = path.resolve(BUILD_DIR); | ||
| const BUILD_ROOT_WITH_SEP = BUILD_ROOT.endsWith(path.sep) ? BUILD_ROOT : BUILD_ROOT + path.sep; | ||
| const CANONICAL_BUILD_ROOT = fs.realpathSync(BUILD_ROOT); | ||
| const CANONICAL_BUILD_ROOT_WITH_SEP = CANONICAL_BUILD_ROOT.endsWith(path.sep) | ||
| ? CANONICAL_BUILD_ROOT | ||
| : CANONICAL_BUILD_ROOT + path.sep; | ||
|
|
||
| const MIME_TYPES = { | ||
| '.html': 'text/html; charset=utf-8', | ||
| '.js': 'text/javascript', | ||
| '.css': 'text/css', | ||
| '.json': 'application/json', | ||
| '.png': 'image/png', | ||
| '.jpg': 'image/jpeg', | ||
| '.gif': 'image/gif', | ||
| '.svg': 'image/svg+xml', | ||
| '.ico': 'image/x-icon', | ||
| '.md': 'text/markdown; charset=utf-8', | ||
| '.txt': 'text/plain; charset=utf-8', | ||
| '.ebnf': 'text/plain; charset=utf-8', | ||
| '.woff': 'font/woff', | ||
| '.woff2': 'font/woff2', | ||
| '.pdf': 'application/pdf', | ||
| }; | ||
|
|
||
| function getContentType(filePath) { | ||
| const ext = path.extname(filePath).toLowerCase(); | ||
| return MIME_TYPES[ext] || 'application/octet-stream'; | ||
| } | ||
|
|
||
| function getCacheControl(filePath) { | ||
| const ext = path.extname(filePath).toLowerCase(); | ||
| if (ext === '.html' || ext === '.txt' || ext === '.md' || ext === '.ebnf') { | ||
| return 'public, max-age=0, must-revalidate'; | ||
| } | ||
| return 'public, max-age=3600'; | ||
| } | ||
|
|
||
| /** | ||
| * Checks whether the request Accept header includes text/markdown. | ||
| */ | ||
| function acceptsMarkdown(req) { | ||
| const accept = req.headers['accept'] || ''; | ||
| return accept.includes('text/markdown'); | ||
| } | ||
|
|
||
| function isCanonicalPathUnderBuildRoot(targetPath) { | ||
| try { | ||
| const realTarget = fs.realpathSync.native ? fs.realpathSync.native(targetPath) : fs.realpathSync(targetPath); | ||
| const realBuildRoot = fs.realpathSync.native ? fs.realpathSync.native(BUILD_ROOT) : fs.realpathSync(BUILD_ROOT); | ||
| const realBuildRootWithSep = realBuildRoot.endsWith(path.sep) ? realBuildRoot : realBuildRoot + path.sep; | ||
| return realTarget === realBuildRoot || realTarget.startsWith(realBuildRootWithSep); | ||
| } catch (e) { | ||
| return false; | ||
| } | ||
| } | ||
|
|
||
| function isSafeRequestPathname(pathname) { | ||
| if (typeof pathname !== 'string' || pathname.length === 0) return false; | ||
| if (!pathname.startsWith('/')) return false; | ||
| if (pathname.includes('\0') || pathname.includes('\\')) return false; | ||
|
|
||
| const segments = pathname.split('/'); | ||
| for (const segment of segments) { | ||
| if (segment === '.' || segment === '..') return false; | ||
| } | ||
|
|
||
| return true; | ||
| } | ||
|
|
||
| function resolveUnderBuildDir(relativePath) { | ||
| let decodedPath; | ||
| try { | ||
| decodedPath = decodeURIComponent(relativePath || '/'); | ||
| } catch (e) { | ||
| return null; | ||
| } | ||
|
|
||
| const normalizedPath = decodedPath.replace(/\\/g, '/'); | ||
| const resolved = path.resolve(BUILD_ROOT, '.' + normalizedPath); | ||
| if (resolved !== BUILD_ROOT && !resolved.startsWith(BUILD_ROOT_WITH_SEP)) { | ||
| return null; | ||
| } | ||
|
|
||
| let canonicalResolved; | ||
| try { | ||
| canonicalResolved = fs.realpathSync(resolved); | ||
| } catch (e) { | ||
| return null; | ||
| } | ||
|
|
||
| if ( | ||
| canonicalResolved !== CANONICAL_BUILD_ROOT && | ||
| !canonicalResolved.startsWith(CANONICAL_BUILD_ROOT_WITH_SEP) | ||
| ) { | ||
| return null; | ||
| } | ||
|
|
||
| return canonicalResolved; | ||
| } | ||
|
|
||
| /** | ||
| * Tries to resolve a markdown file for the given pathname. | ||
| * Maps e.g. "/" -> "index.md", "/foreword" -> "foreword.md", | ||
| * "/move-basics/module" -> "move-basics/module.md". | ||
| */ | ||
| function resolveMarkdownFile(pathname) { | ||
| const clean = pathname.replace(/\/+$/, '') || '/'; | ||
|
|
||
| // Explicit allowlist validation to prevent path traversal and make | ||
| // user-controlled path constraints obvious to static analysis. | ||
| if ( | ||
| !clean.startsWith('/') || | ||
| clean.includes('\0') || | ||
| /(^|\/)\.\.(\/|$)/.test(clean) || | ||
| !/^\/[A-Za-z0-9._/-]*$/.test(clean) | ||
| ) { | ||
| return null; | ||
| } | ||
|
|
||
| if (clean === '/') { | ||
| const candidate = resolveUnderBuildDir('/index.md'); | ||
| if (candidate && fs.existsSync(candidate)) return candidate; | ||
| return null; | ||
| } | ||
|
|
||
| // Try <path>.md first, then <path>/index.md | ||
| const asMd = resolveUnderBuildDir(clean + '.md'); | ||
| if (asMd && fs.existsSync(asMd)) return asMd; | ||
|
|
||
| const asIndex = resolveUnderBuildDir(path.join(clean, 'index.md')); | ||
| if (asIndex && fs.existsSync(asIndex)) return asIndex; | ||
|
jessiemongeon1 marked this conversation as resolved.
Dismissed
|
||
|
|
||
| return null; | ||
| } | ||
|
|
||
| const server = http.createServer((req, res) => { | ||
| const parsedUrl = url.parse(req.url); | ||
| let pathname = parsedUrl.pathname; | ||
|
|
||
| if (!isSafeRequestPathname(pathname)) { | ||
| res.writeHead(400, { 'Content-Type': 'text/plain' }); | ||
| res.end('400 Bad Request'); | ||
| return; | ||
| } | ||
|
|
||
| // Content negotiation: serve markdown when Accept: text/markdown | ||
| if (acceptsMarkdown(req)) { | ||
| const mdFile = resolveMarkdownFile(pathname); | ||
| if (mdFile) { | ||
| const content = fs.readFileSync(mdFile); | ||
|
jessiemongeon1 marked this conversation as resolved.
Dismissed
|
||
| res.writeHead(200, { | ||
| 'Content-Type': 'text/markdown; charset=utf-8', | ||
| 'Content-Disposition': 'inline', | ||
| 'Cache-Control': 'public, max-age=0, must-revalidate', | ||
| }); | ||
| res.end(content); | ||
| return; | ||
| } | ||
| } | ||
|
|
||
| // Resolve file path | ||
| let filePath = resolveUnderBuildDir(pathname); | ||
| if (!filePath) { | ||
| res.writeHead(403, { 'Content-Type': 'text/plain' }); | ||
| res.end('403 Forbidden'); | ||
| return; | ||
| } | ||
|
|
||
| if (!fs.existsSync(filePath)) { | ||
|
github-advanced-security[bot] marked this conversation as resolved.
Fixed
jessiemongeon1 marked this conversation as resolved.
Dismissed
|
||
| // Try index.html for directory-style routes | ||
| const indexPath = resolveUnderBuildDir(path.join(pathname, 'index.html')); | ||
| if (indexPath && fs.existsSync(indexPath)) { | ||
|
jessiemongeon1 marked this conversation as resolved.
Dismissed
|
||
| filePath = indexPath; | ||
| } else { | ||
| res.writeHead(404, { 'Content-Type': 'text/plain' }); | ||
| res.end('404 Not Found'); | ||
| return; | ||
| } | ||
| } else { | ||
| let canonicalFilePath; | ||
| try { | ||
| canonicalFilePath = fs.realpathSync(filePath); | ||
| } catch (e) { | ||
| res.writeHead(404, { 'Content-Type': 'text/plain' }); | ||
| res.end('404 Not Found'); | ||
| return; | ||
| } | ||
|
|
||
| if ( | ||
| canonicalFilePath !== CANONICAL_BUILD_ROOT && | ||
| !canonicalFilePath.startsWith(CANONICAL_BUILD_ROOT_WITH_SEP) | ||
| ) { | ||
| res.writeHead(403, { 'Content-Type': 'text/plain' }); | ||
| res.end('403 Forbidden'); | ||
| return; | ||
| } | ||
|
|
||
| filePath = canonicalFilePath; | ||
|
|
||
| if (fs.statSync(filePath).isDirectory()) { | ||
|
jessiemongeon1 marked this conversation as resolved.
Dismissed
|
||
| const directoryIndexPath = resolveUnderBuildDir(path.join(pathname, 'index.html')); | ||
| if (!directoryIndexPath) { | ||
| res.writeHead(403, { 'Content-Type': 'text/plain' }); | ||
| res.end('403 Forbidden'); | ||
| return; | ||
| } | ||
| filePath = directoryIndexPath; | ||
| } | ||
| } | ||
|
|
||
| if (!fs.existsSync(filePath)) { | ||
|
jessiemongeon1 marked this conversation as resolved.
Dismissed
|
||
| res.writeHead(404, { 'Content-Type': 'text/plain' }); | ||
| res.end('404 Not Found'); | ||
| return; | ||
| } | ||
|
|
||
| if (!isCanonicalPathUnderBuildRoot(filePath)) { | ||
| res.writeHead(403, { 'Content-Type': 'text/plain' }); | ||
| res.end('403 Forbidden'); | ||
| return; | ||
| } | ||
|
|
||
| const content = fs.readFileSync(filePath); | ||
|
jessiemongeon1 marked this conversation as resolved.
Dismissed
|
||
| res.writeHead(200, { | ||
| 'Content-Type': getContentType(filePath), | ||
| 'Content-Disposition': 'inline', | ||
| 'Cache-Control': getCacheControl(filePath), | ||
| }); | ||
| res.end(content); | ||
| }); | ||
|
|
||
| server.listen(PORT, () => { | ||
| console.log(`Serving build at http://localhost:${PORT}/`); | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.