sui-rpc: answer duplicate executions from the ledger#287
Merged
Conversation
Previously, execute_transaction_and_wait_for_checkpoint only consulted the ledger after the execution RPC returned successfully. A resubmission of an already committed transaction had to wait out (or hang on) the execution call, and an execution error was surfaced even when the transaction had actually committed, so callers saw a failure for a transaction that succeeded. With this commit the method also probes GetTransaction while the execution RPC is in flight and returns immediately when the probe finds the transaction in a checkpoint. When execution fails, the ledger is consulted once more before the error is surfaced, and a committed transaction is returned as success. Responses answered from the ledger are assembled with the request's read mask plus the digest, checkpoint, and timestamp fields the method always populates. Also add mock-server tests for the probe short-circuit and both execution-error outcomes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, execute_transaction_and_wait_for_checkpoint only consulted the ledger after the execution RPC returned successfully. A resubmission of an already committed transaction had to wait out (or hang on) the execution call, and an execution error was surfaced even when the transaction had actually committed, so callers saw a failure for a transaction that succeeded.
With this commit the method also probes GetTransaction while the execution RPC is in flight and returns immediately when the probe finds the transaction in a checkpoint. When execution fails, the ledger is consulted once more before the error is surfaced, and a committed transaction is returned as success. Responses answered from the ledger are assembled with the request's read mask plus the digest, checkpoint, and timestamp fields the method always populates. Also add mock-server tests for the probe short-circuit and both execution-error outcomes.