Skip to content

feat: use sha256 to check file integrity #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
luojiyin1987 wants to merge 18 commits into
base: main
Choose a base branch
from
Open

feat: use sha256 to check file integrity #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
b963898
feat: use sha256 to check file integrity
luojiyin1987 Jul 28, 2025
4a3ea90
feat: check window zip
luojiyin1987 Jul 28, 2025
34c6333
feat: parse_checksum_file
luojiyin1987 Jul 28, 2025
c560d4b
feat: more error info && get user tips
luojiyin1987 Jul 28, 2025
63bfe02
warn info friendly
luojiyin1987 Jul 28, 2025
3536ac5
code clear
luojiyin1987 Jul 28, 2025
3c21422
fix: sha256 error
luojiyin1987 Jul 28, 2025
a272b38
fix: code clear
luojiyin1987 Jul 30, 2025
d13bd47
refactor: download_checksum
luojiyin1987 Jul 30, 2025
b710816
refactor: verify_download_integrity
luojiyin1987 Jul 30, 2025
ad96f93
fix: windows version info note
luojiyin1987 Aug 4, 2025
bb84e8b
fix: INTEGRITY_CHECK_SKIPPED to SKIP_INTEGRITY_CHECK
luojiyin1987 Aug 4, 2025
7da9db3
fix: no support windows x86_64
luojiyin1987 Aug 4, 2025
42ed9ce
fix: sh compatibility
luojiyin1987 Aug 5, 2025
856e3e8
doc: update readme
luojiyin1987 Aug 8, 2025
ff1565d
feat: improve checksum verification error handling for MD5
luojiyin1987 Aug 8, 2025
a4e860c
fix: check path in windows
luojiyin1987 Aug 8, 2025
fc72c59
doc: update readme
luojiyin1987 Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,11 @@ With `suiup`, you can:

### From Script
```bash
curl -sSfL https://raw.githubusercontent.com/Mystenlabs/suiup/main/install.sh | sh
curl -sSfL https://raw.githubusercontent.com/Mystenlabs/suiup/main/install.sh | bash
Copy link
Copy Markdown
Collaborator

@stefan-mysten stefan-mysten Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why to change to bash?

Copy link
Copy Markdown
Contributor Author

@luojiyin1987 luojiyin1987 Aug 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

local is a keyword specific to bash, used to declare local variables. There is no local keyword in standard sh.
local ist nicht Teil des POSIX-Shell-Standards.

On Linux distributions (such as CentOS, Fedora, RHEL, openSUSE, macOS), /bin/sh is indeed a symbolic link (symlink) pointing to /bin/bash. So in most cases, there is no problem.

In Debian and its derivatives (such as Ubuntu), /bin/sh does not point to bash by default, but rather to a lighter-weight shell that more strictly adheres to POSIX standards—dash. This differs from bash support.

In order to detect problems earlier, it is recommended to use bash.

Copy link
Copy Markdown
Contributor Author

@luojiyin1987 luojiyin1987 Aug 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use shellcheck to check compatibility between different shells @stefan-mysten

```

> [!TIP]
> Set `SUIUP_INSTALL_DIR` environment variable to customize the installation directory: `SUIUP_INSTALL_DIR=/custom/path curl -sSfL ... | sh`
> Set `SUIUP_INSTALL_DIR` environment variable to customize the installation directory: `SUIUP_INSTALL_DIR=/custom/path curl -sSfL ... | bash`

### From Cargo
```bash
Expand Down
Loading