Skip to content

Hotkey recording in Settings Window#296

Open
memohnsen wants to merge 4 commits into
MystikoLab:masterfrom
memohnsen:hotkey-recording-settings
Open

Hotkey recording in Settings Window#296
memohnsen wants to merge 4 commits into
MystikoLab:masterfrom
memohnsen:hotkey-recording-settings

Conversation

@memohnsen

Copy link
Copy Markdown
Contributor

This PR references a discord conversation about adding hotkey recording support in the Settings UI for both toggle the view and opening the clipboard history. This PR also cleans up a clippy error from the settings UI change that had dead code for reset fields no longer in use.

New Behavior

  • Tapping on the hotkey text field starts recording key presses
  • Esc ends recording and saves new config
  • At least one modifier key is required
  • Keybindings cannot be the same as others used within Rustcast
  • Keybindings are written to config file same style as before, no breaking changes
Screen.Recording.2026-07-11.at.15.30.43.mov

@unsecretised

Copy link
Copy Markdown
Collaborator

I think the code is ok, just that maybe it should also be applicable to the shell commands hotkeys

@memohnsen

Copy link
Copy Markdown
Contributor Author

added and merge conflicts fixed

@unsecretised unsecretised left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed the code.. I'll try out the implementation and then I'll approve

Comment thread src/app/pages/settings.rs

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should consider using a custom widget so that we can simply add this to the commands tab as well.

@unsecretised unsecretised left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work as intended, but the only issue is, i've noticed that when i change something in the settings, the hotkeys stop working. Can that be fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants