Restrict No window! error log message to mythfrontend #1276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MythVideoProfile::InitStatics() gets called for several applications, including mythfrontend, mythtranscode, mythcommflag, and mythpreviewgen. An error log gets generated when the application does not have control of the myth main window. However, this only makes sense for mythfrontend. This code change adds a test for the frontend, and will only generate the error log message if that test is true. Resolves: MythTV#1018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MythVideoProfile::InitStatics() gets called for several applications, including mythfrontend, mythtranscode, mythcommflag, and mythpreviewgen. An error log gets generated when the application does not have control of the MythTv main window. However, this only makes sense for mythfrontend.
This code change will only allow generation of the error log message for the mythfrontend application. We still return out of the function for non-frontend applications because failing to do so will lead to errors. The code which follows tries to create a QWidget which cannot be done without a QApplication which cannot be created without a MythTv main window to run it in.
Resolves: #1018
Checklist