Copy & Paste of Activity Directives between Plans #1627

ivydeliz · 2025-02-10T21:16:19Z

Extending the original Copy & Paste feature with a few things here...

Let's use the system Clipboard, instead of session storage. This will allow us to deconflict having a separate special clipboard for Aerie, and it enables more features like...
Copy & Paste between plans. Open two plans, you can copy from plan A and paste on plan B either on the table or on the timeline at a specific time.
Now that we handle different plans, they can have different boundaries, so if you're pasting and the earliest start is out of bounds, then we're going to paste at the start of the plan.

src/components/activity/ActivityDirectivesTable.svelte

duranb · 2025-02-11T20:29:17Z

src/components/activity/ActivityDirectivesTable.svelte

+  function canPasteActivityDirectives(): Promise<number> {
+    return new Promise(resolve => {
+      getActivityDirectivesClipboardCount().then(result => {
+        if (plan !== null && hasCreatePermission && result > 0) {


I think it's okay to use hasCreatePermission here, but our convention for permissions has been to disallow the user from being able to click on the option to paste and displayed a tooltip stating why they're unable to click. It just lets them know quicker why something isn't available to them.

duranb · 2025-02-11T20:30:47Z

src/components/activity/ActivityDirectivesTable.svelte

-      <ContextMenuItem on:click={pasteActivityDirectives}>{getPasteActivityDirectivesText()}</ContextMenuItem>
-      <ContextMenuSeparator></ContextMenuSeparator>
-    {/if}
+    {#await canPasteActivityDirectives() then howMany}


Can we keep this option always visible, but disabled if they don't have anything to paste in?

duranb · 2025-02-11T20:33:04Z

src/utilities/clipboard.ts

+    try {
+      window.navigator.clipboard.readText().then(clipText => resolve(clipText));
+    } catch (e) {
+      resolve(`{}`); //empty object string?


Does this need to be an object string or can we just return null?

ivydeliz · 2025-02-13T18:01:18Z

@duranb addressed feedback! and actually simplified it! Give it a look when you can.

AaronPlave · 2025-02-14T16:48:37Z

src/utilities/activities.ts

    }
  } catch (e) {
-    console.error(e);
-    return false;
+    //eh silent


Any reason not to spit out a log here?

Actually I remember why we keep this silent. This throws an error if the clipboard has something that is not json, like general string/clipboard things. It should fail silently.

Oh makes sense. Could you update the comment there with a note about that so that future us/others don't throw a log there?

src/utilities/activities.ts

duranb · 2025-02-19T19:37:12Z

src/components/activity/ActivityDirectivesTable.svelte

+                  return 'You do not have permission create activity directives';
+                } else if (directivesInClipboard <= 0) {
+                  return 'No activity directives in clipboard';
+                }


Can you add a final return statement for if the logic falls through all the conditionals?

Do you mind saving the permissionError to a variable that gets updated in a reactive statement? We generally save the error to a local state variable so that it's calculated only when the dependent variables change and not every time the component re-renders.

duranb · 2025-02-19T19:42:19Z

src/components/activity/ActivityDirectivesTable.svelte

The showCopyMenu variable seems to no longer be being set to anything else in this file. Can we remove it and just pass true into the BulkActionDataGrid's showCopyMenu prop?

duranb · 2025-02-19T19:43:24Z

src/components/timeline/TimelineContextMenu.svelte

@@ -432,18 +428,35 @@
      >
        Set Simulation End
      </ContextMenuItem>
-      {#if canPasteActivityDirectives()}
+      {#await getActivityDirectivesClipboardCount() then directivesInClipboard}


Is there still a chance that this menu item won't show while it's loading the count? Is it always quick to pop in?

I'm sure there's still a chance if you're trying to copy/paste tens of thousands of activities

Yeah that makes sense. Can we instead save the count to a variable and instead of awaiting to show the menu option, just show the option with a 0 count and disabling it to be consistent with always showing options?

@duranb since we're using the system clipboard we first need to make sure the clipboard has activity directives and then we get how many there are. So keeping the count doesn't really help me because we still have to deserialize the clipboard to see if it's the right type of content.

duranb · 2025-02-19T19:45:08Z

src/utilities/clipboard.ts

@@ -0,0 +1,26 @@
+export function setClipboardContent(content: object, success?: () => void, fail?: () => void) {
+  navigator.permissions.query({ name: 'clipboard-write' as PermissionName }).then(result => {


PermissionName is missing a type definition

@duranb not sure I understand this one!

I'm getting PermissionName as an unresolved type from typescript.

Ok it looks like we dont need this after all so i removed that section.

duranb · 2025-02-19T19:45:49Z

src/utilities/clipboard.ts

+  });
+}
+
+export async function getClipboardContent(): Promise<string | undefined> {


I think this needs to return void instead of undefined.

sonarqubecloud · 2025-02-25T03:22:28Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

ivydeliz temporarily deployed to test-workflow February 10, 2025 21:16 — with GitHub Actions Inactive

ivydeliz temporarily deployed to test-workflow February 10, 2025 21:21 — with GitHub Actions Inactive

ivydeliz force-pushed the feature/copy-paste-directives-between-plans branch from fab1cfa to e5c2ec1 Compare February 10, 2025 21:28

ivydeliz had a problem deploying to test-workflow February 10, 2025 21:28 — with GitHub Actions Failure

ivydeliz self-assigned this Feb 10, 2025

ivydeliz had a problem deploying to test-workflow February 10, 2025 21:42 — with GitHub Actions Failure

ivydeliz marked this pull request as ready for review February 10, 2025 21:53

ivydeliz requested a review from a team as a code owner February 10, 2025 21:53

ivydeliz requested review from dandelany, AaronPlave and joswig February 10, 2025 21:53

ivydeliz changed the title ~~Copy & Paste of Activity Directives between Plans (#1625)~~ Copy & Paste of Activity Directives between Plans Feb 10, 2025

ivydeliz had a problem deploying to test-workflow February 10, 2025 21:54 — with GitHub Actions Failure

duranb requested changes Feb 11, 2025

View reviewed changes

ivydeliz temporarily deployed to test-workflow February 11, 2025 21:38 — with GitHub Actions Inactive

ivydeliz force-pushed the feature/copy-paste-directives-between-plans branch from e5c2ec1 to 258e0ba Compare February 13, 2025 17:40

ivydeliz temporarily deployed to test-workflow February 13, 2025 17:40 — with GitHub Actions Inactive

ivydeliz force-pushed the feature/copy-paste-directives-between-plans branch from 258e0ba to 3796dac Compare February 13, 2025 17:50

ivydeliz temporarily deployed to test-workflow February 13, 2025 17:50 — with GitHub Actions Inactive

ivydeliz requested a review from duranb February 13, 2025 18:00

AaronPlave reviewed Feb 14, 2025

View reviewed changes

src/utilities/activities.ts Outdated Show resolved Hide resolved

duranb requested changes Feb 19, 2025

View reviewed changes

ivydeliz force-pushed the feature/copy-paste-directives-between-plans branch from 3796dac to 0f7ae85 Compare February 20, 2025 04:19

ivydeliz temporarily deployed to test-workflow February 20, 2025 04:19 — with GitHub Actions Inactive

Copy & Paste of Activity Directives between Plans (#1625)

848dfbe

ivydeliz force-pushed the feature/copy-paste-directives-between-plans branch from 0f7ae85 to 848dfbe Compare February 25, 2025 03:21

ivydeliz deployed to test-workflow February 25, 2025 03:21 — with GitHub Actions Active

ivydeliz requested a review from duranb February 25, 2025 03:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Copy & Paste of Activity Directives between Plans #1627

Copy & Paste of Activity Directives between Plans #1627

ivydeliz commented Feb 10, 2025 •

edited

Loading

duranb Feb 11, 2025

duranb Feb 11, 2025

duranb Feb 11, 2025

ivydeliz commented Feb 13, 2025 •

edited

Loading

AaronPlave Feb 14, 2025

This comment was marked as outdated.

ivydeliz Feb 20, 2025 •

edited

Loading

AaronPlave Feb 20, 2025

duranb Feb 19, 2025

duranb Feb 19, 2025

duranb Feb 19, 2025

duranb Feb 19, 2025

ivydeliz Feb 20, 2025

duranb Feb 20, 2025

ivydeliz Feb 25, 2025 •

edited

Loading

duranb Feb 19, 2025

ivydeliz Feb 20, 2025

duranb Feb 20, 2025

ivydeliz Feb 25, 2025

duranb Feb 19, 2025

sonarqubecloud bot commented Feb 25, 2025

		@@ -0,0 +1,26 @@
		export function setClipboardContent(content: object, success?: () => void, fail?: () => void) {
		navigator.permissions.query({ name: 'clipboard-write' as PermissionName }).then(result => {

Copy & Paste of Activity Directives between Plans #1627

Are you sure you want to change the base?

Copy & Paste of Activity Directives between Plans #1627

Conversation

ivydeliz commented Feb 10, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ivydeliz commented Feb 13, 2025 • edited Loading

Choose a reason for hiding this comment

This comment was marked as outdated.

ivydeliz Feb 20, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ivydeliz Feb 25, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Feb 25, 2025

Quality Gate passed

ivydeliz commented Feb 10, 2025 •

edited

Loading

ivydeliz commented Feb 13, 2025 •

edited

Loading

ivydeliz Feb 20, 2025 •

edited

Loading

ivydeliz Feb 25, 2025 •

edited

Loading