Skip to content

Copy & Paste of Activity Directives between Plans #1627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2025
Merged

Copy & Paste of Activity Directives between Plans #1627

merged 1 commit into from
Mar 10, 2025

Conversation

ivydeliz
Copy link
Contributor

@ivydeliz ivydeliz commented Feb 10, 2025 •
edited by dandelany
Loading

Closes #1625

Extending the original Copy & Paste feature with a few things here...

  1. Let's use the system Clipboard, instead of session storage. This will allow us to deconflict having a separate special clipboard for Aerie, and it enables more features like...
  2. Copy & Paste between plans. Open two plans, you can copy from plan A and paste on plan B either on the table or on the timeline at a specific time.
  3. Now that we handle different plans, they can have different boundaries, so if you're pasting and the earliest start is out of bounds, then we're going to paste at the start of the plan.

@ivydeliz ivydeliz force-pushed the feature/copy-paste-directives-between-plans branch from fab1cfa to e5c2ec1 Compare February 10, 2025 21:28
@ivydeliz ivydeliz self-assigned this Feb 10, 2025
@ivydeliz ivydeliz marked this pull request as ready for review February 10, 2025 21:53
@ivydeliz ivydeliz requested a review from a team as a code owner February 10, 2025 21:53
@ivydeliz ivydeliz changed the title Copy & Paste of Activity Directives between Plans (#1625) Copy & Paste of Activity Directives between Plans Feb 10, 2025
duranb
duranb requested changes Feb 11, 2025
View reviewed changes
@ivydeliz ivydeliz force-pushed the feature/copy-paste-directives-between-plans branch from e5c2ec1 to 258e0ba Compare February 13, 2025 17:40
@ivydeliz ivydeliz force-pushed the feature/copy-paste-directives-between-plans branch from 258e0ba to 3796dac Compare February 13, 2025 17:50
@ivydeliz ivydeliz requested a review from duranb February 13, 2025 18:00
@ivydeliz
Copy link
Contributor Author

ivydeliz commented Feb 13, 2025 •
edited
Loading

@duranb addressed feedback! and actually simplified it! Give it a look when you can.

AaronPlave
AaronPlave reviewed Feb 14, 2025
View reviewed changes
AaronPlave
AaronPlave reviewed Feb 14, 2025
View reviewed changes
duranb
duranb requested changes Feb 19, 2025
View reviewed changes
@ivydeliz ivydeliz force-pushed the feature/copy-paste-directives-between-plans branch from 3796dac to 0f7ae85 Compare February 20, 2025 04:19
@ivydeliz ivydeliz force-pushed the feature/copy-paste-directives-between-plans branch from 0f7ae85 to 848dfbe Compare February 25, 2025 03:21
@ivydeliz ivydeliz requested a review from duranb February 25, 2025 03:23
duranb
duranb requested changes Feb 26, 2025
View reviewed changes
@ivydeliz ivydeliz force-pushed the feature/copy-paste-directives-between-plans branch from 848dfbe to 1207af9 Compare February 28, 2025 16:35
@ivydeliz ivydeliz force-pushed the feature/copy-paste-directives-between-plans branch from 1207af9 to df56a00 Compare March 7, 2025 22:29
@ivydeliz ivydeliz force-pushed the feature/copy-paste-directives-between-plans branch from df56a00 to cd42f88 Compare March 7, 2025 22:40
@ivydeliz ivydeliz force-pushed the feature/copy-paste-directives-between-plans branch from cd42f88 to 4d42ad5 Compare March 7, 2025 22:43
@ivydeliz ivydeliz force-pushed the feature/copy-paste-directives-between-plans branch from 4d42ad5 to aaf0d6b Compare March 7, 2025 22:46
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 7, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ivydeliz
Copy link
Contributor Author

ivydeliz commented Mar 7, 2025

Alright! Bryan worked with me to create a PasteContextMenuItem so it is reused between the Activity Directives Table and the Timeline. Here you go! Please review at your convenience.

@ivydeliz ivydeliz requested a review from duranb March 7, 2025 22:57
@ivydeliz ivydeliz added the feature New feature or request label Mar 7, 2025
duranb
duranb approved these changes Mar 10, 2025
View reviewed changes
Copy link
Collaborator

@duranb duranb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work! lgtm!

@ivydeliz ivydeliz merged commit e482792 into develop Mar 10, 2025
7 of 8 checks passed
@ivydeliz ivydeliz deleted the feature/copy-paste-directives-between-plans branch March 10, 2025 16:22
@github-project-automation github-project-automation bot moved this from Todo to Done in Aerie Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronPlave AaronPlave AaronPlave left review comments

@duranb duranb duranb approved these changes

@dandelany dandelany Awaiting requested review from dandelany dandelany is a code owner automatically assigned from NASA-AMMOS/aerie-frontend

@joswig joswig Awaiting requested review from joswig joswig is a code owner automatically assigned from NASA-AMMOS/aerie-frontend

Assignees

@ivydeliz ivydeliz

Labels
feature New feature or request
Projects
Aerie
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Copy & Paste of Activity Directives between Plans
4 participants
@ivydeliz @AaronPlave @duranb @dandelany