Simplify action run logs viewer and add JSON download#1932
Merged
Conversation
AaronPlave
requested review from
dandelany
and removed request for
joswig and
mattdailis
Action server logs were rendering through ConsoleLog (the error-console component built around <details>/expandable rows), making text selection and copy/paste fragile. Replace with a dedicated ActionRunLogs component that renders entries as a tight monospace block — no chevrons, no expand markers, so vertical selection copies cleanly in source order. The log parser moves out of the Svelte file into utilities/actions.ts as parseActionLogLines, with its own ParsedActionLog type (severed from LogMessage/ErrorTypes, which carry error-console-specific fields). The Error block also migrates to ActionRunLogs (single-entry array) so the two blocks render uniformly; the red wrapper keeps the visual accent. Adds a Download button next to Re-run that exports the full run as JSON (metadata + parameters + settings + error + results + parsed logs) via the existing downloadJSON utility.
dandelany
force-pushed
the
feat/action-logs-simplification
branch
from
2cc6176 to
676bcdf
Compare
dandelany
approved these changes
May 26, 2026
Collaborator
dandelany
left a comment
dandelany
left a comment
There was a problem hiding this comment.
Thanks for coming back to this. Confirmed it fixes the annoying log copy/paste behavior we saw before, avoids the complexity around expand/collapsing logs, and we got the JSON run info download button as a bonus.
I added one small change to include the action run's canceled flag in the JSON download file. Ready to merge when tests pass 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ConsoleLogrendering in the action-run output with a newActionRunLogscomponent — a tight monospace block (no chevrons, no expandable rows) so vertical text selection copies cleanly in source order, like GitHub Actions logs.downloadJSONutility.utilities/actions.tsasparseActionLogLineswith its ownParsedActionLogtype, and migrate the Error block to render throughActionRunLogstoo so both blocks share formatting (the red wrapper keeps the Error section visually distinct).Test plan
ConsoleLog's palette).{action-name}-{runId}.jsondownloads. Open it: object withid,status,requestedAt,requestedBy,duration,parameters,settings,error,results, andlogs: [{ timestamp, level, message, trace?, data? }, ...].results.data→ Results block renders unchanged.logs: nullshows the italic "No logs" placeholder; Download button still functions.