Skip to content

Close plan branches modal on branch select#1939

Merged
AaronPlave merged 1 commit into
developfrom
fix/1937/branch-modal-closure
Jun 1, 2026
Merged

Close plan branches modal on branch select#1939
AaronPlave merged 1 commit into
developfrom
fix/1937/branch-modal-closure

Conversation

@AaronPlave
Copy link
Copy Markdown
Contributor

@AaronPlave AaronPlave commented May 29, 2026

Close plan branches modal when user clicks on a branch. Prevents closure when user has meta/ctrl key pressed to preserve open in new tab/window behavior. Closes #1937.

Verification

  1. Create plan
  2. Add activity
  3. Create plan branch
  4. Go back to parent plan
  5. Open plan branches modal
  6. Click on child branch
  7. Branch should load and modal should close
  8. Reopen branches modal from parent plan
  9. Control/command click (windows/mac) on child branch and ensure it opens in new tab and doesn't close modal

…llow for opening link in another tab/window.
@AaronPlave AaronPlave self-assigned this May 29, 2026
@AaronPlave AaronPlave requested a review from a team as a code owner May 29, 2026 19:37
@AaronPlave AaronPlave added the fix A bug fix label May 29, 2026
@AaronPlave AaronPlave requested review from dandelany, duranb and joswig May 29, 2026 19:37
@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Collaborator

@dandelany dandelany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good, tested locally!

@AaronPlave AaronPlave merged commit a54572a into develop Jun 1, 2026
12 checks passed
@AaronPlave AaronPlave deleted the fix/1937/branch-modal-closure branch June 1, 2026 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Branches" modal does not close when swapping branches

2 participants