Skip to content

Fix workspace collaborator input overflow #1955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AaronPlave wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix workspace collaborator input overflow #1955

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/components/ui/Tags/TagsInput.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
closeSuggestions();
};
export let allowMultiple: boolean = true;
export let boxClassName: string = 'max-h-[40vh]';
export let createTagObject: (name: string) => Tag = (name: string) => {
return { color: generateRandomPastelColor(), created_at: '', id: -1, name, owner: '' };
};
Expand Down Expand Up @@ -234,7 +235,7 @@

<div
class={classNames(
'flex max-h-[40vh] gap-2 overflow-hidden rounded-md border border-input bg-background p-[2px] focus-within:ring-2 focus-within:ring-ring',
`flex ${boxClassName} gap-2 overflow-hidden rounded-md border border-input bg-background p-[2px] focus-within:ring-2 focus-within:ring-ring`,
{
[className]: !!className,
'cursor-not-allowed opacity-50': disabled,
Expand Down
2 changes: 2 additions & 0 deletions src/components/ui/Tags/UserInput.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import UserInputRow from './UserInputRow.svelte';

export let allowMultiple: boolean = true;
export let boxClassName: string = 'max-h-[40vh]';
export let className: string = '';
export let disabled: boolean = false;
export let name: string = '';
Expand Down Expand Up @@ -136,6 +137,7 @@
bind:this={inputRef}
{addTag}
{allowMultiple}
{boxClassName}
{disabled}
{className}
showPlaceholderIfDisabled
Expand Down
1 change: 1 addition & 0 deletions src/components/ui/Tags/WorkspaceCollaboratorInput.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@
</script>

<UserInput
boxClassName="max-h-none"
className="w-full"
placeholder="Search collaborators or workspaces"
selectedUsers={collaborators.map(({ collaborator }) => collaborator)}
Expand Down
4 changes: 2 additions & 2 deletions src/components/workspace/WorkspaceSidebar.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@
</script>

<div class="flex h-full w-full flex-col">
<div class="h-full min-h-[300px]" role="tabpanel">
<div class="h-full min-h-0" role="tabpanel">
{#if activeTab === 'files'}
<div class="grid h-full grid-rows-[min-content_auto]">
<Sidebar.Header className="p-0">
Expand Down Expand Up @@ -257,7 +257,7 @@
</select>
</Input>
</fieldset>
<fieldset>
<fieldset class="pb-4">
<Input layout="stacked">
<label use:tooltip={{ content: 'Collaborators', placement: 'top' }} for="collaborators">
Collaborators
Expand Down
Loading