Conversation
|
Thanks for opening this @jsignell. The docker image building/pushing for PR push events has been useful as a bit of a workaround for when we need to publish slight variations of the pangeo-notebook-veda-image from other branches that we might or might not merge into main. But I think we can simply use the on demand image building feature of the hubs for that. So happy to merge this and stop building images from PRs. @batpad @wildintellect let me know if you have strong opinions here. |
|
hmm. Maybe my description was unclear or maybe I am missing something. This PR is meant to remove the actions that do not actually push the image after they build it. So after this PR instead of there being 2 actions every time I add a commit to a PR there will be just one and that action will build and push the image. |
|
Ahh! Thank you for this catch and fix @jsignell 🙏 much appreciated - the double-build was annoying. |
|
🤔 is it supposed to build on every branch? https://github.com/NASA-IMPACT/pangeo-notebook-veda-image/actions/runs/16576415968 <- I didn't expect this to build. |
We did have it setup that way so that it would run tests, test that the built was successful AND give us a built image we could use to test with the "Bring your own Image" feature. This was also useful to create one-off images that we could easily test. Now that we have the "Build your own Image" feature, we could maaybe no longer push images from branches - but I do think it's nice to still run the tests and do the build in CI? |
|
Yeah I don't think there is any harm in pushing built images from every branch. We don't do it for forks so no real harm IMO |
4 participants
This PR reverts #5. The only reason to run actions on PR is to allow CI to run on PRs from forks, but that's not necessary for this repo. It's redundant to run the exact same CI twice and it's confusing that only actions that are triggered by push events end up pushing the image to docker.