Skip to content

Upgrade to pangeo-notebook 2025.12.30#54

Merged
jsignell merged 13 commits intomainfrom
upgrade/pangeo-2025.12.30
Jan 27, 2026
Merged

Upgrade to pangeo-notebook 2025.12.30#54
jsignell merged 13 commits intomainfrom
upgrade/pangeo-2025.12.30

Conversation

@jsignell
Copy link
Copy Markdown
Collaborator

@jsignell jsignell commented Jan 2, 2026

Closes #52

Also:

  • remove pins on pystac and geoviews now that newer versions are released
  • remove icechunk and virtualizarr now that they are upstreamed
  • remove stac_ipyleaflet Remove stac_ipyleaflet #51

@jsignell jsignell linked an issue Jan 2, 2026 that may be closed by this pull request
@jsignell
Copy link
Copy Markdown
Collaborator Author

jsignell commented Jan 2, 2026

I think the failures are due to an issue with pytest>=9 and pytest-notebook (ref chrisjsewell/pytest-notebook#83)

@jsignell
Copy link
Copy Markdown
Collaborator Author

jsignell commented Jan 2, 2026

Hmmm. This passes locally.

@jsignell
Copy link
Copy Markdown
Collaborator Author

jsignell commented Jan 2, 2026

ah ha! I just learned that run_test.sh is not actually what gets run on CI. It is this: https://github.com/jupyterhub/repo2docker-action/blob/daa77f929833dcd836a711bc7837af945e9d27cc/create_docker_image.sh#L149-L168

@jsignell
Copy link
Copy Markdown
Collaborator Author

jsignell commented Jan 2, 2026

@jsignell
Copy link
Copy Markdown
Collaborator Author

jsignell commented Jan 2, 2026

Ok nice it seems like that change in repo2docker-action does the trick. I'm going to undo c0004ff now

@jsignell
Copy link
Copy Markdown
Collaborator Author

@yuvipanda suggested that we just use the fork to avoid pinning in the action itself.

@wildintellect
Copy link
Copy Markdown
Contributor

@jsignell I can confirm that public.ecr.aws/nasa-veda/pangeo-notebook-veda-image:f20ed0ce5027 boots. Should we manually test some notebooks before merging?

@jsignell
Copy link
Copy Markdown
Collaborator Author

So far I have found two issues:

  1. dask gateway never successfully scales the cluster. It seems like the scale request never really gets through to the cluster. So it's not even trying to get more workers. I haven't figured out yet whether this is jupyterhub-specific but it sure feels like it is.

reproducer:

from dask_gateway import Gateway

gateway = Gateway()
cluster = gateway.new_cluster()
cluster.scale(2)

Nothing ever happens. No workers come online and no workers seem to be trying to come online.

  1. hvplot dynamic plots never update: moving the sliders, changing dropdowns have no impact. This one is almost certainly jupyterhub-specific

reproducer:

import hvplot.xarray  # noqa

air_ds = hvplot.sampledata.air_temperature("xarray")
air_ds.hvplot.image(data_aspect=1, frame_width=400, dynamic=True)

switch to a different time, image doesn't change.

@jsignell
Copy link
Copy Markdown
Collaborator Author

I just tried both of these in the existing pangeo image and they don't work there either. So while this isn't a great state of affairs, it doesn't seem to be worse.

@wildintellect
Copy link
Copy Markdown
Contributor

@jsignell sounds like we should report upstream in a few places, but go ahead with this merge.

  • Report broken docs in VEDA-docs
  • Open a ticket about dask gateway with veda-jupyterhub/2i2c
  • who should get the hvplot ticket?

@jsignell
Copy link
Copy Markdown
Collaborator Author

who should get the hvplot ticket?

Yeah I was trying to figure that out as well. I opened holoviz/holoviews#6787 in the meantime. Although I suspect this is hub/jupyter-myst specific.

@jsignell
Copy link
Copy Markdown
Collaborator Author

Ok! The jupyterhub team has resolved the dask-gateway issue and it looks like pinning down pyviz_comms has resolved the hvplot issue. So I think this one is good to merge and an improvement over the current default pangeo image.

@jsignell
Copy link
Copy Markdown
Collaborator Author

I had written it up in NASA-IMPACT/veda-jupyterhub#105 so the links are all in there.

@jsignell jsignell merged commit 7af523a into main Jan 27, 2026
1 check passed
@jsignell jsignell deleted the upgrade/pangeo-2025.12.30 branch January 27, 2026 19:22
@jsignell jsignell mentioned this pull request Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Once it's available - Update to new pangeo image Remove stac_ipyleaflet

2 participants