Conversation
|
I think the failures are due to an issue with pytest>=9 and pytest-notebook (ref chrisjsewell/pytest-notebook#83) |
|
Hmmm. This passes locally. |
|
ah ha! I just learned that |
|
Ok nice it seems like that change in repo2docker-action does the trick. I'm going to undo c0004ff now |
|
@yuvipanda suggested that we just use the fork to avoid pinning in the action itself. |
|
@jsignell I can confirm that public.ecr.aws/nasa-veda/pangeo-notebook-veda-image:f20ed0ce5027 boots. Should we manually test some notebooks before merging? |
|
So far I have found two issues:
reproducer: from dask_gateway import Gateway
gateway = Gateway()
cluster = gateway.new_cluster()
cluster.scale(2)Nothing ever happens. No workers come online and no workers seem to be trying to come online.
reproducer: import hvplot.xarray # noqa
air_ds = hvplot.sampledata.air_temperature("xarray")
air_ds.hvplot.image(data_aspect=1, frame_width=400, dynamic=True)switch to a different time, image doesn't change. |
|
I just tried both of these in the existing pangeo image and they don't work there either. So while this isn't a great state of affairs, it doesn't seem to be worse. |
|
@jsignell sounds like we should report upstream in a few places, but go ahead with this merge.
|
Yeah I was trying to figure that out as well. I opened holoviz/holoviews#6787 in the meantime. Although I suspect this is hub/jupyter-myst specific. |
|
Ok! The jupyterhub team has resolved the dask-gateway issue and it looks like pinning down pyviz_comms has resolved the hvplot issue. So I think this one is good to merge and an improvement over the current default pangeo image. |
|
I had written it up in NASA-IMPACT/veda-jupyterhub#105 so the links are all in there. |
Closes #52
Also:
stac_ipyleaflet#51