Fix/dynamic dag args #314
Merged
Fix/dynamic dag args #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anayeaye
requested review from
alukach,
botanical,
ividito,
amarouane-ABDELHAK and
smohiudd
anayeaye
commented
Mar 13, 2025
anayeaye
commented
Mar 13, 2025
| **dag_args | ||
| ) as dag: | ||
| start = DummyOperator(task_id="Start", dag=dag) | ||
| end = DummyOperator(task_id="End", trigger_rule=TriggerRule.ONE_SUCCESS, dag=dag) | ||
| discover = discover_from_s3_task() | ||
| discover = discover_from_s3_task(event) |
There was a problem hiding this comment.
Making the params explicit here made it easier to see why the scheduled DAG was failing without an event but the default user-triggered DAG was working (because the run config is submitted when starting a manual run)
anayeaye
commented
Mar 13, 2025
anayeaye
commented
Mar 13, 2025
smohiudd
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Some code updates for clarity (not across the full codebase, just in discovery and vector DAGs)