Skip to content

feat: remove vector security group inbound rule resource#389

Open
botanical wants to merge 1 commit into
devfrom
feat/remove-sg-rule-for-ingest
Open

feat: remove vector security group inbound rule resource#389
botanical wants to merge 1 commit into
devfrom
feat/remove-sg-rule-for-ingest

Conversation

@botanical

@botanical botanical commented Jul 24, 2025

Copy link
Copy Markdown
Member

Summary:

Companion PR NASA-IMPACT/veda-features-api-cdk#36
Related ticket NASA-IMPACT/veda-features-api-cdk#16

Changes

  • This PR removes the resource that manages adding an inbound security group rule on behalf of the Airflow worker for the Vector/Features security group. We will be managing this resource in the features api repo.

PR Checklist

  • Unit tests
  • Ad-hoc testing - Deploy changes and test manually
  • Integration tests
  • Infrastructure changes - test using terraform validate and terraform plan

@botanical
botanical marked this pull request as ready for review July 24, 2025 16:46

@anayeaye anayeaye left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I think we will have to be methodical about cycling the change to existing stages to make sure that we re-establish connectivity to the features database

@botanical

Copy link
Copy Markdown
Member Author

This looks good. I think we will have to be methodical about cycling the change to existing stages to make sure that we re-establish connectivity to the features database

Agreed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants