Skip to content

Conversation

@saikishor
Copy link
Contributor

This updates the on_init API to the updated one and this is compatible with the rolling version of the ros2_control package.

@saikishor
Copy link
Contributor Author

I thought you were not using pre-conmit. Perfect. I'll update it. I don't get why the other check fails

@saikishor saikishor force-pushed the update/system_interface/API branch from ecf796d to 99d2116 Compare November 18, 2025 21:59
@eholum-nasa
Copy link
Member

Thanks so much for these updates, @saikishor! This was on the back burner so appreciate you taking it on...

I don't get why the other check fails

Ah sorry, this is a branch naming issue. We use the branch name to uniquely identify docker images that are built in CI and it doesn't like /, as it's an invalid image name. I had a long term goal of actually pushing and saving images but for now it doesn't even really matter. Pixi builds are fine and it runs fine for me so I'll do a quick sanity check and just merge past it!

/usr/bin/docker buildx build --build-arg ROS_DISTRO=jazzy --file docker/Dockerfile --iidfile /home/runner/work/_temp/docker-actions-toolkit-6Go0da/build-iidfile-5b3ded6a0a.txt --secret id=GIT_AUTH_TOKEN,src=/home/runner/work/_temp/docker-actions-toolkit-6Go0da/tmp-2599-IMyNfj4HRnoS --tag mujoco_ros2_simulation:update/system_interface/API --target mujoco_ros --load --metadata-file /home/runner/work/_temp/docker-actions-toolkit-6Go0da/build-metadata-168882991b.json https://github.com/NASA-JSC-Robotics/mujoco_ros2_simulation.git#refs/pull/36/merge
ERROR: failed to build: invalid tag "mujoco_ros2_simulation:update/system_interface/API": invalid reference format
Error: buildx failed with: ERROR: failed to build: invalid tag "mujoco_ros2_simulation:update/system_interface/API": invalid reference format

@saikishor
Copy link
Contributor Author

@eholum-nasa thanks for letting me know. Then, I'll create the other upcoming PRs without /. Thank you

Copy link
Member

@eholum-nasa eholum-nasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eholum-nasa eholum-nasa merged commit aec5adb into NASA-JSC-Robotics:jazzy-devel Nov 19, 2025
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants