Add megabits/s and gigabits/s as units of Rate - #1066
Open
jshughes wants to merge 5 commits into
Open
Conversation
Tests for control, two new units, and error.
|
jmafi
approved these changes
Aug 7, 2026
jmafi
left a comment
There was a problem hiding this comment.
I'm not sure what many of these files are (".pins", ".feature", ".pont", ".pprj"), but the diffs on them look to be in line with requested changes on CCB#91. The test labels also look good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Add more units of Rate: megabits/s and gigabits/s
🗒️ Summary
Added two new units of rate, megabits/s and gigabits/s, to unit_id in Units_of_Rates
🤖 AI Assistance Disclosure
Estimated % of code influenced by AI: 10 %
Identify and debug Cucumber tests.
⚙️ Test Data and/or Report
github1065 - Added four validate tests: one control, two valid, and one invalid.
♻️ Related Issues
fixes #1065
refs #91
🤓 Reviewer Checklist
Reviewers: Please verify the following before approving this pull request.
Documentation and PR Content
Security & Quality
Testing & Validation
Maintenance
Terraform (only if this PR touches a
terraform/directory)scripts/validate_terraform.pywas run against the changedterraform/tree and any Must-Have failures were resolved (or are tracked in a reviewed.tfvalidate-ignoreentry, not silently bypassed).pdc-cds-infra, not duplicated in an application repo.modules/stays flat and no new module is just a thin wrapper around a single resource./pds/<component>/...and, if this PR is the consumer side, reads from the correct published parameter rather than another repo's Terraform state.