Add fresh flag to suggested cmake commands for testing #699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peverwhee
requested review from
climbfuji,
dustinswales,
gold2718,
grantfirl,
mkavulich and
mwaxmonsky
as code owners
climbfuji
reviewed
Dec 1, 2025
Collaborator
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
Should we also make this change in .github/{workflows,actions}/* ?
Collaborator
Author
|
@DomHeinzeller good call - can't hurt. done! |
climbfuji
approved these changes
Dec 1, 2025
Collaborator
Collaborator
Author
|
@climbfuji I bet @gold2718 means that we should add the flag to the README in the new nested suites test (which doesn't exist on develop yet) |
Collaborator
Got it, thanks. I added it as a suggestion so that we can add it before merging and don't forget. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
--freshflag to example cmake commands; tests don't otherwise pick up changes without a clean build directory.