Skip to content

bugfix: Github CI and Dockerfile#572

Merged
scrasmussen merged 3 commits intoNCAR:mainfrom
scrasmussen:bugfix/docker-test-and-push-ci
Apr 7, 2025
Merged

bugfix: Github CI and Dockerfile#572
scrasmussen merged 3 commits intoNCAR:mainfrom
scrasmussen:bugfix/docker-test-and-push-ci

Conversation

@scrasmussen
Copy link
Copy Markdown
Member

@scrasmussen scrasmussen commented Mar 25, 2025

SOURCE: Soren Rasmussen, NSF NCAR

DESCRIPTION OF CHANGES: The build_test_and_push_docker Github CI always fails for an unknown reason on the main branch, turning this check off. The other changes are attempt to reduce the amount of time spent during the Docker image build and reduce the information produced. Changes are:

  • Turn off build_test_and_push_docker Github CI for merge of PR into main branch
  • Unifying apt-get install into one command (modern coding practice)
  • using slim debian docker image
  • git clones of depth=1 so less data is downloaded
  • download test datasets only if running in the PR CI
  • build_test_and_push_docker Github CI runs 3 minutes faster

TESTS CONDUCTED: Built docker image locally

@scrasmussen scrasmussen force-pushed the bugfix/docker-test-and-push-ci branch from 9a0a794 to 071f772 Compare March 25, 2025 19:32
@scrasmussen scrasmussen changed the title bugfix: slimming down Dockerfile bugfix: Github CI and Dockerfile Mar 25, 2025
- using slim debian docker image
- git clones of depth=1 so less data is downloaded
- only download test datasets for PR
@scrasmussen scrasmussen force-pushed the bugfix/docker-test-and-push-ci branch from 3e775b4 to 628897b Compare April 3, 2025 16:52
@scrasmussen scrasmussen force-pushed the bugfix/docker-test-and-push-ci branch from 219dfe3 to 432bfa9 Compare April 3, 2025 18:08
@scrasmussen scrasmussen merged commit 565d548 into NCAR:main Apr 7, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants