fix: write to standard io error unit#574
Merged
scrasmussen merged 1 commit intoNCAR:mainfrom May 8, 2025
Merged
Conversation
scrasmussen
requested review from
dustinswales,
grantfirl,
hertneky and
mkavulich
as code owners
grantfirl
approved these changes
Apr 1, 2025
Collaborator
|
@scrasmussen RE: CCPP_typedefs.F90, I'd rather not push those changes back to fv3atm because it probably opens up a can of worms in that repo. |
scrasmussen
force-pushed
the
bugfix/write-to-standard-io-units
branch
2 times, most recently
from
e84ed9f to
2cbe923
Compare
Member
Author
This makes a lot of sense! Reverted the changes to |
scrasmussen
force-pushed
the
bugfix/write-to-standard-io-units
branch
from
2cbe923 to
77b5b08
Compare
Member
Author
|
Converted to draft, waiting for PR #570 to be merged and there will be a few lines that will need to be changed |
Collaborator
|
@scrasmussen FYI, #570 was merged. |
…t that is a warning or error. The python scripts capture this as stderr output
scrasmussen
force-pushed
the
bugfix/write-to-standard-io-units
branch
from
77b5b08 to
4db5bb4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SOURCE: Soren Rasmussen, NSF NCAR
DESCRIPTION OF CHANGES:
iso_fortran_enverror_unitwhen writing output that is a warning or error. Therun_scm.pypython script captures this asstderroutput and in the future the script can better handle this information.TESTS CONDUCTED: built with GNU modules on Derecho
NOTE: Do the changes to
CCPP_typedefs.F90need to be also PR'ed elsewhere?