Conversation
…data and let physics control it the rest of the way; update nstf_name in physics namelists to make sure that spinup is on for the SCM
scrasmussen
reviewed
Mar 28, 2025
scrasmussen
approved these changes
Mar 28, 2025
Member
scrasmussen
left a comment
There was a problem hiding this comment.
Changes look good to me! Probably want another reviewer with a better understanding of the physics but from a coding stand point it seems good to me.
hertneky
approved these changes
Mar 31, 2025
Collaborator
hertneky
left a comment
There was a problem hiding this comment.
These changes look good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following discussion with @hertneky, this changes the following:
xz) to 20.0 m to match UFSifdor the flag to turn on NSST to 1.0 if the surface is ocean; this only has an effect if prescribed surface fluxes are off and NSST is in the SDF and nstf_name(1) > 0.-- if
ifdstarts as zero, NSST code can eventually set it to 1 if the model time is after 6 AM local time and ifd starts as 0, but during some cases, it was noticed thatifdwouldn't change to 1 (and therefore activate NSST) until the first "sunrise" after the model initializes (e.g. if a case started at noon,ifdwouldn't set itself to 1 until the next morning, even though NSST should be active immediately)New functionality needed for @bluefinweiwei:
do_sst_initialize_onlynamelist variable (default value of F) to the case configuration namelist; if set to T, scm_state%T_surf (which gets pointed to by thesea_surface_temperaturevariable) only gets initialized from the case data file SST value. The default/original behavior is that when thesurface_forcing_tempvariable in the DEPHY-formatted case data file is set tots(or any of the other options too, for that matter), the scm_state%T_surf gets updated from the case forcing file every timestep and physics has very little "authority" over this variable -- it may get changed during the physics call, but it will get reset when forcing occurs. The new behavior allows physics (including NSST) to change sea_surface_temperature how it wants to.