Skip to content

ufs-community ccpp-physics PR260 memcheck fixes #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scrasmussen merged 4 commits into from
May 1, 2025
Merged

ufs-community ccpp-physics PR260 memcheck fixes #581

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9f4469a
fv3atm PR#937: Memcheck fixes
scrasmussen Apr 18, 2025
8cd11a9
ccpp-physics hash: fv3atm PR#937: Memcheck fixes
scrasmussen Apr 18, 2025
3733919
for testing ccpp-physics branch ufs-dev-PR260-memcheck-fixes
scrasmussen Apr 18, 2025
8c33dc1
Merge branch 'main' into ufs-community-ccpp-physics-260-memcheck-fixes
grantfirl Apr 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .gitmodules
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
branch = main
[submodule "ccpp-physics"]
path = ccpp/physics
url = https://github.com/NCAR/ccpp-physics
branch = main
url = https://github.com/scrasmussen/ccpp-physics
branch = ufs-dev-PR260-memcheck-fixes
[submodule "CMakeModules"]
path = CMakeModules
url = https://github.com/noaa-emc/CMakeModules
Expand Down
2 changes: 1 addition & 1 deletion ccpp/physics
Open in desktop
Submodule physics updated 18 files
+1 −1 physics/CONV/Grell_Freitas/cu_gf_deep.F90
+38 −38 physics/GWD/cires_tauamf_data.F90
+1 −1 physics/GWD/ugwp_driver_v0.F
+1 −2 physics/Interstitials/UFS_SCM_NEPTUNE/module_ccpp_suite_simulator.F90
+5 −0 physics/Interstitials/UFS_SCM_NEPTUNE/sfcsub.F
+1 −1 physics/MP/GFDL/module_gfdl_cloud_microphys.F90
+37 −75 physics/MP/Thompson/module_mp_thompson.F90
+0 −86 physics/MP/Thompson/mp_thompson.F90
+1 −1 physics/PBL/MYNN_EDMF/module_bl_mynn.F90
+12 −12 physics/SFC_Models/Lake/CLM/clm_lake.f90
+20 −20 physics/SFC_Models/Land/Noah/set_soilveg.f
+1 −1 physics/SFC_Models/Land/Noah/sflx.f
+2 −7 physics/SFC_Models/Land/Noahmp/lnd_iau_mod.F90
+64 −66 physics/SFC_Models/Land/Noahmp/module_sf_noahmp_glacier.F90
+53 −55 physics/SFC_Models/Land/Noahmp/module_sf_noahmplsm.F90
+3 −5 physics/SFC_Models/Land/Noahmp/noahmpdrv.F90
+18 −18 physics/SFC_Models/Land/RUC/set_soilveg_ruc.F90
+3 −4 physics/SFC_Models/SeaIce/CICE/sfc_sice.f
11 changes: 4 additions & 7 deletions scm/src/GFS_typedefs.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ module GFS_typedefs
integer, parameter :: dfi_radar_max_intervals = 4 !< Number of radar-derived temperature tendency and/or convection suppression intervals. Do not change.

real(kind=kind_phys), parameter :: limit_unspecified = 1e12 !< special constant for "namelist value was not provided" in radar-derived temperature tendency limit range

integer, parameter :: no_tracer = -99

!> \section arg_table_GFS_typedefs
Expand Down Expand Up @@ -2485,7 +2485,6 @@ subroutine sfcprop_create (Sfcprop, Model)
allocate (Sfcprop%slope_save (IM))
allocate (Sfcprop%shdmin (IM))
allocate (Sfcprop%shdmax (IM))
allocate (Sfcprop%snoalb (IM))
allocate (Sfcprop%tg3 (IM))
allocate (Sfcprop%vfrac (IM))
allocate (Sfcprop%vtype (IM))
Expand All @@ -2505,7 +2504,6 @@ subroutine sfcprop_create (Sfcprop, Model)
Sfcprop%slope_save = zero
Sfcprop%shdmin = clear_val
Sfcprop%shdmax = clear_val
Sfcprop%snoalb = clear_val
Sfcprop%tg3 = clear_val
Sfcprop%vfrac = clear_val
Sfcprop%vtype = zero
Expand Down Expand Up @@ -4284,9 +4282,8 @@ subroutine control_initialize (Model, nlunit, fn_nml, me, master, &

!--- read in the namelist
#ifdef INTERNAL_FILE_NML
! allocate required to work around GNU compiler bug 100886 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100886
allocate (Model%input_nml_file, mold=input_nml_file)
Model%input_nml_file => input_nml_file
Model%input_nml_file = input_nml_file
read(Model%input_nml_file, nml=gfs_physics_nml)
! Set length (number of lines) in namelist for internal reads
Model%input_nml_file_length = size(Model%input_nml_file)
Expand Down Expand Up @@ -8419,12 +8416,12 @@ subroutine diag_phys_zero (Diag, Model, linit, iauwindow_center)
endif

end subroutine diag_phys_zero

function get_tracer_index (tracer_names, name)

character(len=32), intent(in) :: tracer_names(:)
character(len=*), intent(in) :: name

!--- local variables
integer :: get_tracer_index
integer :: i
Expand Down