Skip to content

Remove references to physcons module from SCM #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
scrasmussen wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove references to physcons module from SCM #653

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scm/src/GFS_typedefs.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3411,7 +3411,7 @@ subroutine control_initialize (Model, nlunit, fn_nml, me, &
cny, gnx, gny, ak, bk, hydrostatic)

!--- modules
use physcons, only: con_rerth, con_pi, con_p0, rhowater
use scm_physical_constants, only: con_rerth, con_pi, con_p0, rhowater
use mersenne_twister, only: random_setseed, random_number
use GFS_ccpp_suite_sim_pre, only: load_ccpp_suite_sim
!
Expand Down
2 changes: 1 addition & 1 deletion scm/src/GFS_typedefs.meta
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10619,7 +10619,7 @@
name = GFS_typedefs
type = module
dependencies_path = ../../ccpp/physics/physics
dependencies = hooks/machine.F,hooks/physcons.F90
dependencies = hooks/machine.F
dependencies = Radiation/RRTMG/radlw_param.f,Radiation/RRTMG/radsw_param.f
dependencies = MP/TEMPO/TEMPO/module_mp_tempo_params.F90
dependencies = photochem/module_ozphys.F90,photochem/module_h2ophys.F90
Expand Down
27 changes: 23 additions & 4 deletions scm/src/scm_physical_constants.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ module scm_physical_constants
!!
integer ,parameter:: con_zero =0
real(kind=dp),parameter:: con_pi =3.1415926535897931

real(kind=dp),parameter:: con_rerth =6.3712e+6
real(kind=dp),parameter:: con_g =9.80665e+0
real(kind=dp),parameter:: con_omega =7.2921e-5
Expand Down Expand Up @@ -42,8 +42,9 @@ module scm_physical_constants
real(kind=dp),parameter:: con_avgd =6.0221415e23_dp
real(kind=dp),parameter:: con_amd =28.9644_dp !< molecular wght of dry air (\f$g/mol\f$)
real(kind=dp),parameter:: con_amw =18.0154_dp
real(kind=dp),parameter:: con_amo3 =47.9982_dp !< molecular wght of o3 (\f$g/mol\f$)
real(kind=dp),parameter:: karman =0.4_dp

real(kind=dp),parameter:: cimin =0.15
!> minimum rain amount
real(kind=dp),parameter:: rainmin =1.e-13_dp
Expand All @@ -52,7 +53,7 @@ module scm_physical_constants
real(kind=dp),parameter:: con_rhw0 =1022.0
real(kind=dp),parameter:: con_sbc =5.670400e-8
real(kind=dp),parameter:: con_tice =2.7120e+2

real(kind=dp),parameter:: rhowater =1000._dp
real(kind=dp),parameter:: rholakeice = 0.917e3_dp !< density of ice on lake (kg/m^3)

Expand All @@ -63,10 +64,28 @@ module scm_physical_constants
real(kind=dp),parameter:: con_solr_2002 = 1.3660e+3_dp !< solar constant (\f$W/m^{2}\f$)-Liu(2002)
real(kind=dp),parameter:: con_solr_2008 = 1.3608e+3_dp !< solar constant (\f$W/m^{2}\f$)-nasa-sorce Tim(2008)
real(kind=dp),parameter:: con_thgni = -38.15_dp !< temperature the H.G.Nuc. ice starts

! for gfdlmp v3
real(kind=dp), parameter:: con_rhoair_IFS = 1.0 ! reference air density (kg/m^3), ref: IFS
real(kind=dp), parameter:: con_rhosnow = 100.0 ! density of snow (kg/m^3)
real(kind=dp), parameter :: con_visd = 1.717e-5 ! dynamics viscosity of air at 0 deg C and 1000 hPa (Mason, 1971) (kg/m/s)
real(kind=dp), parameter :: con_visk = 1.35e-5 ! kinematic viscosity of air at 0 deg C and 1000 hPa (Mason, 1971) (m^2/s)
real(kind=dp), parameter :: con_vdifu = 2.25e-5 ! diffusivity of water vapor in air at 0 deg C and 1000 hPa (Mason, 1971) (m^2/s)
real(kind=dp), parameter :: con_tcond = 2.40e-2 ! thermal conductivity of air at 0 deg C and 1000 hPa (Mason, 1971) (J/m/s/K)
real(kind=dp), parameter :: con_cdg = 3.15121 ! drag coefficient of graupel (Locatelli and Hobbs, 1974)
real(kind=dp), parameter :: con_cdh = 0.5 ! drag coefficient of hail (Heymsfield and Wright, 2014)
real(kind=dp), parameter :: con_rhocw = 1.0e3 ! density of cloud water (kg/m^3)
real(kind=dp), parameter :: con_rhoci = 9.17e2 ! density of cloud ice (kg/m^3)
real(kind=dp), parameter :: con_rhocr = 1.0e3 ! density of rain (Lin et al. 1983) (kg/m^3)
real(kind=dp), parameter :: con_rhocg = 4.0e2 ! density of graupel (Rutledge and Hobbs 1984) (kg/m^3)
real(kind=dp), parameter :: con_rhoch = 9.17e2 ! density of hail (Lin et al. 1983) (kg/m^3)
real(kind=dp), parameter :: con_qcmin = 1.0e-15 ! min value for cloud condensates (kg/kg)
real(kind=dp), parameter :: con_qfmin = 1.0e-8 ! min value for sedimentation (kg/kg)
real(kind=dp), parameter :: con_one = 1_dp
real(kind=dp), parameter :: con_p001 = 0.001_dp
real(kind=dp), parameter :: con_secinday = 86400._dp

! --- constants from physcons.F90 ---
real(kind=dp),parameter:: con_decorr = 2.50_dp !< Decorrelation length constant (km) for iovr = 4 or 5 and idcor = 0
real(kind=dp),parameter:: con_qamin = 1.e-16_dp !< Minimum aerosol concentration
end module scm_physical_constants
130 changes: 128 additions & 2 deletions scm/src/scm_physical_constants.meta
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
units = kg kg-1
dimensions = ()
type = real
kind = kind_phys
kind = kind_phys
[con_epsm1]
standard_name = ratio_of_dry_air_to_water_vapor_gas_constants_minus_one
long_name = (rd/rv) - 1
Expand Down Expand Up @@ -340,4 +340,130 @@
units = s
dimensions = ()
type = real
kind = kind_phys
kind = kind_phys
[con_amo3]
standard_name = molecular_weight_of_ozone
long_name = molecular weight of ozone
units = g mol-1
dimensions = ()
type = real
kind = kind_phys
[con_decorr]
standard_name = decorrelation_length_constant
long_name = Decorrelation length constant (km) for iovr = 4 or 5 and idcor = 0
units = km
dimensions = ()
type = real
kind = kind_phys
[con_qamin]
standard_name = minimum_aerosol_concentration
long_name = Minimum aerosol mass mixing ratio
units = kg kg-1
dimensions = ()
type = real
kind = kind_phys
[con_rhoair_IFS]
standard_name = density_of_air_IFS
long_name = density of air IFS
units = kg m-3
dimensions = ()
type = real
kind = kind_phys
[con_rhosnow]
standard_name = density_of_snow
long_name = density of snow
units = kg m-3
dimensions = ()
type = real
kind = kind_phys
[con_visd]
standard_name = dynamic_viscosity_of_air
long_name = dynamic viscosity of air at 0 deg C and 1000 hPa (Mason, 1971)
units = kg m-1 s-1
dimensions = ()
type = real
kind = kind_phys
[con_visk]
standard_name = kinematic_viscosity_of_air
long_name = kinematic viscosity of air at 0 deg C and 1000 hPa (Mason, 1971)
units = m2 s-1
dimensions = ()
type = real
kind = kind_phys
[con_vdifu]
standard_name = diffusivity_of_water_vapor_in_air
long_name = diffusivity of water vapor in air at 0 deg C and 1000 hPa (Mason, 1971)
units = m2 s-1
dimensions = ()
type = real
kind = kind_phys
[con_tcond]
standard_name = thermal_conductivity_of_air
long_name = thermal conductivity of air at 0 deg C and 1000 hPa (Mason, 1971)
units = W m-1 K-1
dimensions = ()
type = real
kind = kind_phys
[con_cdg]
standard_name = drag_coefficient_of_graupel
long_name = drag coefficient of graupel (Locatelli and Hobbs, 1974)
units = 1
dimensions = ()
type = real
kind = kind_phys
[con_cdh]
standard_name = drag_coefficient_of_hail
long_name = drag coefficient of hail (Heymsfield and Wright, 2014)
units = 1
dimensions = ()
type = real
kind = kind_phys
[con_rhocw]
standard_name = density_of_cloud_water
long_name = density of cloud water
units = kg m-3
dimensions = ()
type = real
kind = kind_phys
[con_rhoci]
standard_name = density_of_cloud_ice
long_name = density of cloud ice
units = kg m-3
dimensions = ()
type = real
kind = kind_phys
[con_rhocr]
standard_name = density_of_rain
long_name = density of rain (Lin et al., 1983)
units = kg m-3
dimensions = ()
type = real
kind = kind_phys
[con_rhocg]
standard_name = density_of_graupel
long_name = density of graupel (Rutledge and Hobbs, 1984)
units = kg m-3
dimensions = ()
type = real
kind = kind_phys
[con_rhoch]
standard_name = density_of_hail
long_name = density of hail (Lin et al., 1983)
units = kg m-3
dimensions = ()
type = real
kind = kind_phys
[con_qcmin]
standard_name = minimum_mass_mixing_ratio_of_cloud_condensate
long_name = minimum value for cloud condensates
units = kg kg-1
dimensions = ()
type = real
kind = kind_phys
[con_qfmin]
standard_name = minimum_mass_mixing_ratio_for_sedimentation
long_name = minimum value for sedimentation
units = kg kg-1
dimensions = ()
type = real
kind = kind_phys
4 changes: 2 additions & 2 deletions scm/src/scm_setup.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,7 @@ subroutine GFS_suite_setup (Model, Statein, Stateout, Sfcprop,
GFS_control_type, GFS_grid_type, &
GFS_tbd_type, GFS_cldprop_type, &
GFS_radtend_type, GFS_diag_type
use physcons, only: pi => con_pi
use scm_physical_constants, only: pi => con_pi


!use cldwat2m_micro, only: ini_micro
Expand Down Expand Up @@ -406,7 +406,7 @@ end subroutine GFS_suite_setup
!------------------
subroutine GFS_grid_populate (Grid, xlon, xlat, area)
use machine, only: kind_phys
use physcons, only: pi => con_pi
use scm_physical_constants, only: pi => con_pi
use GFS_typedefs, only: GFS_grid_type

implicit none
Expand Down
Loading