Update: spack stack 2.0.0 (for Intel) and 2.1.0 (for GNU) and ip library#662
Update: spack stack 2.0.0 (for Intel) and 2.1.0 (for GNU) and ip library#662scrasmussen wants to merge 19 commits intoNCAR:mainfrom
Conversation
|
@scrasmussen I ran tests on derecho with this PR. GNU w/ 1.9.3 Builds and runs SCM fine Did you ever discover what the issue with running the SCM was for Intel on Derecho? Do you want me to look into it? LMK |
@hertneky I haven't had time to dive into why the SCM is failing with an Intel executable. I'll be able to look into it a bit more next week. If we want to merge this in sooner I can split off the intel stuff until we can get it to run. Or we can add a note when the spack stack 2.0 intel modules are loaded that the SCM is failing at runtime with them |
@scrasmussen That's what I wasn't sure about either, whether it was fine to merge this knowing intel is broken for running SCM. Do others have thoughts? @grantfirl @dustinswales |
|
I'd also like to get this working on Ursa before merging this. I can work on that. |
|
@scrasmussen @hertneky I just uploaded a module file for spack-stack-2.0.0 using ip on Ursa. It successfully compiled and ran a case. I also made a new spack-stack-2.0.0 python virtual environment to use there in /scratch3/BMC/gmtb/ccpp-scm-software. |
|
@scrasmussen Also, no issues on Ursa for using -O2. If issues persist on Derecho, we should test for which machine is being used before reducing optimization, IMO. |
|
@scrasmussen @hertneky Also added a GNU module file and python environment using spack-stack 2.0.0. Everything works with GNU too. |
|
I also tested the code using the spack-stack-1.9.1 module on Ursa (without ip), and it successfully built/ran, so it will successfully fall back to the sp library if necessary. |
|
@scrasmussen I removed the -O0 in the scm/src/CMakeLists.txt since it is apparently a known issue with too many suites that will be addressed in a future PR. Are there any problems remaining on Derecho? |
ec62701 to
0d97d66
Compare
|
@scrasmussen I had several commits into this PR branch, including ursa module files for using spack stack 2.0. Where did those commits go? |
Dang, I didn't pull before rebasing, sorry about that! I'll fix this, thanks for pointing this out! |
…Not running on Derecho, will create an issue with the RC helpdesk
…s not officially support GNU on Derecho
… be built, so that suite should also be supported
…o_intel - Adding GNU Spack Stack 2.1.0. Intel Spack Stack 2.1.0 is currently broken
7dce610 to
d6d217a
Compare
|
I believe this PR is now ready to be merged after people review it. Things I updated and tested today:
|
scm/src/supported_suites.py
Outdated
| @@ -1,2 +1 @@ | |||
| suites = ["SCM_GFS_v16","SCM_GFS_v16_RRTMGP","SCM_GFS_v17_p8_ugwpv1","SCM_HRRR_gf","SCM_WoFS_v0"] | |||
|
|
|||
| suites = ["SCM_GFS_v16","SCM_GFS_v16_ps","SCM_GFS_v16_RRTMGP","SCM_GFS_v17_p8_ugwpv1","SCM_HRRR_gf","SCM_WoFS_v0"] | |||
There was a problem hiding this comment.
I don't think that adding SCM_GFS_v16_ps should be necessary. Let me look.
There was a problem hiding this comment.
I don't think that supported_suites and supported_cases are actually used anymore by anything. I really don't understand why this was necessary.
There was a problem hiding this comment.
I and I believe @hertneky, use supported suites and cases as the minimum list of suites and cases to test. I didn't use them before ifx, because I'd just use Intel to build everything at once.
I agree they don't seem to be used by anything, so if they don't represent the minimum list of suites and cases we support, we might want to discuss removing these files in the SCM meeting.
There was a problem hiding this comment.
Ya, I think these have been entirely supplanted by suite_info.py. I think that they should be removed.
There was a problem hiding this comment.
Ok, I see now, thanks for the explanation! I'll add a commit removing those two files
|
FYI, this now depends on NCAR/ccpp-physics#1208 |
|
@scrasmussen There will be an incoming PR into your PR branch to add functionality to compile suites based on the |
|
@scrasmussen Please see scrasmussen#11 I uses this successfully on derecho using intel and gnu. The only issue that I ran into was the interactive session didn't have enough memory for the RRTMGP runs by default. |
Add rl type
…een supplanted by suite_info.py
…echo. Using this method since emacs is not in the spack stack build
SOURCE: Soren Rasmussen, NSF NCAR
DESCRIPTION OF CHANGES:
iplibrary if it is found. Thesplibrary is being replaced byipso this is required. Note that in spack-stack theippackage builds with the OpenMP flag so it gets turned on in the CMake build. The RRTMGP files currently break if compiled with OpenMP flags so theCMAKE_Fortran_FLAGS_OPENMP_OFFenvironment variable will make sure OpenMP isn't used by the RRTMGP files.bacio::bacio_4tobacio::bacioin spack-stack 2.0.0-O0. It fails at runtime on Derecho though, this will need to investigated more.ASSOCIATED PRs:
TESTS CONDUCTED: Built on Derecho with GNU and Intel. GNU successfully ran the scm cases but Intel is failing.
Contributors:
Built on work from @climbfuji in NCAR/ccpp-physics#1090 and #524