Skip to content

Conversation

@cenlinhe
Copy link
Collaborator

@cenlinhe cenlinhe commented Dec 28, 2024

This PR is to submit the code changes made for coupling Noah-MPv5.0 with NASA LIS system through the GitHub submodule mechanisms.

  • The main change is creating a new driver subfolder for LIS/Noah-MPv5.0 interface.
  • The LIS/Noah-MPv5.0 coupling PR related to this PR is here: LIS/Noah-MPv5.0 coupling NASA-LIS/LISF#1666
  • Nothing was changed for the Noah-MP core physics code in this PR.
  • The model code has been tested, benchmarked, and evaluated by the NCAR team in the NCAR's HPC (Derecho) and has recently been tested in NASA's HPC by David Mocko for both LSM run and DA of soil moisture and snow.
  • The model benchmark and evaluation results are currently submitted to Geoscientific Model Development (GMD) through the manuscript of "Benchmarking and evaluating the NASA Land Information System coupled with the refactored Noah-MP land surface model version 5.0"

Code contributor: Cenlin He (NCAR; [email protected])
Model test contributors: Cenlin He (NCAR), Tzu-Shun Lin (NCAR), David Mocko (NASA/LIS)

cenlinhe added 24 commits July 13, 2023 16:58
Sync with latest Develop branch
Sync with latest develop branch
Sync with latest NCAR noahmp/release-v5.0-LIS branch
use consistent common undefined value for initialization
sync with NCAR/noahmp v5.0-LIS branch
Sync with develop branch for bug fix
Sync latest develop branch bug fix to LIS noahmp code
Bug fix for domain size input variable
Copy link
Collaborator

@tslin2 tslin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

driver codes to couple with LIS, testing runs are complete

@cenlinhe
Copy link
Collaborator Author

cenlinhe commented Jan 5, 2025

@RAbolafiaRosenzweig Could you please take a look at this PR and approve it if everything looks good to you?

Copy link
Collaborator

@RAbolafiaRosenzweig RAbolafiaRosenzweig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test configuration/compilation/runs approved.

@cenlinhe cenlinhe merged commit ac29818 into develop Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants