Support int64 for station_id, time, and lake_id #847
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates output files to support int64 for station_id and time. This is to align with the equivalent change that was made years back on what I believe must be the official NWM output side of things (which used "feature_id" instead of "station_id"). For example, all of the official NWM outputs for the Alaska domain correctly use int64 for the feature_id variable with no data loss.
TYPE: bug fix
KEYWORDS: dtype, netcdf, output, int64
SOURCE: Shawn Crawley (NOAA Affiliate via Lynker)
DESCRIPTION OF CHANGES: The dtype of a few output NetCDF variables was changed from int to int64.
ISSUE: My input RouteLink.nc file supports INT64 in the "link", "from", and "to" columns. The CHRTOUT_DOMAIN output NetCDF files had the associated links - stored as "station_id" - recast to int32, and thus were converted to 10-digits that no longer matched the input.
TESTS CONDUCTED: I just manually made the changes herein, recompiled, reran my simulation and checked that the results were as hoped.
There may be other spots that a similar update is needed. I only did so for the few that were unique to my situation.