Skip to content

bugfix: reach channel and high process count#898

Open
scrasmussen wants to merge 1 commit into
NCAR:mainfrom
scrasmussen:fix/high-np-reach-channel
Open

bugfix: reach channel and high process count#898
scrasmussen wants to merge 1 commit into
NCAR:mainfrom
scrasmussen:fix/high-np-reach-channel

Conversation

@scrasmussen

@scrasmussen scrasmussen commented Jun 4, 2026

Copy link
Copy Markdown
Member

TYPE: bugfix

KEYWORDS: reach routing, domain decomposition

SOURCE: Soren Rasmussen, NSF NCAR

DESCRIPTION OF CHANGES:

  • bugfix: if a core in a reach based run as 0 nlinks, defining certain variables might make it crash

ISSUE: #865

TESTS CONDUCTED: Croton reach testcase runs with np=96. Before the fix it was producing the following error

...
#1  0x58a471 in __module_nwm_io_MOD_output_chrt_nwm
        at src/Routing/module_NWM_io.F90:318
#2  0x5d186d in __module_hydro_drv_MOD_hydro_out
        at src/HYDRO_drv/module_HYDRO_drv.F90:346
#3  0x5cf43e in __module_hydro_drv_MOD_hydro_exe
        at src/HYDRO_drv/module_HYDRO_drv.F90:737
...

@scrasmussen scrasmussen force-pushed the fix/high-np-reach-channel branch 2 times, most recently from 20efd1a to 6051bd4 Compare June 10, 2026 17:23
@scrasmussen scrasmussen force-pushed the fix/high-np-reach-channel branch from 6051bd4 to 93ee2ce Compare June 26, 2026 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants