Skip to content

hotfix: unitialized variable g_qloss_gwsubbas #902

Merged
scrasmussen merged 1 commit into
NCAR:mainfrom
scrasmussen:bugfix/groundwater-bucket-loss
Jun 8, 2026
Merged

hotfix: unitialized variable g_qloss_gwsubbas #902
scrasmussen merged 1 commit into
NCAR:mainfrom
scrasmussen:bugfix/groundwater-bucket-loss

Conversation

@scrasmussen

@scrasmussen scrasmussen commented Jun 5, 2026

Copy link
Copy Markdown
Member

TYPE: bugfix

KEYWORDS: routing, CI

SOURCE: Soren Rasmussen, NSF NCAR

DESCRIPTION OF CHANGES:

  • g_qloss_gwsubbas was unitialized if bucket_loss equals 0
  • running Croton reach lakes fails when compiled with -ffpe-trap=invalid flag, tracked it down to this variable
  • this seems to be the reason the reach_lakes CI test is failing

ISSUE: #897

TESTS CONDUCTED: Ran reach lakes locally with extra debug flags. Fixes reach lakes CI failure

@scrasmussen scrasmussen requested review from aubreyd and rcabell June 5, 2026 21:53
@scrasmussen scrasmussen changed the title bugfix: unitialized variable g_qloss_gwsubbas hotfix: unitialized variable g_qloss_gwsubbas Jun 6, 2026

@rcabell rcabell left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! This looks appropriate with no obvious side effects.

@scrasmussen scrasmussen merged commit fe64f39 into NCAR:main Jun 8, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants