Merged
Conversation
added 4 commits
March 12, 2026 13:45
…p of right panel. Closes #18
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses issues #17, #18, and #22 by adding glob and URI file-open modes, moving field selection info to the plot area, adding a collapse method documentation link, and introducing new configurable settings for field list rows, coordinate slider visibility, and default plot output format/filename.
Changes:
- Added glob file open dialog and URI stub, replaced combined file/folder picker with separate file and folder pickers
- Moved selection info display from left panel to the right-hand plot area, using
__repr__for field details - Added new settings (field list rows, coordinate slider rows, plot filename template, plot format) with validation and UI controls
Reviewed changes
Copilot reviewed 9 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| xconv2/xconv_cf_interface.py | Simplified field_info to use str(x) instead of manual coordinate/cell assembly |
| xconv2/ui/settings_store.py | Added defaults and validation for new settings |
| xconv2/ui/selection_controller.py | Use custom InputDialogCustom with doc link for collapse methods |
| xconv2/ui/plot_view_controller.py | Added plot_info_output widget; multi-format save dialog |
| xconv2/ui/menu_controller.py | Added "Open Glob..." and "Open URIs..." menu actions |
| xconv2/ui/field_metadata_controller.py | Route selection info to new right-panel widget |
| xconv2/ui/dialogs.py | New InputDialogCustom and OpenGlobDialog classes |
| xconv2/ui/init.py | Export new dialog classes |
| xconv2/core_window.py | Glob/URI handlers, new settings accessors, layout restructuring, tray icon update |
| xconv2/assets/cf-logo-box.svg | New box-style app icon |
| xconv2/assets/cf-logo-box.png | New box-style app icon (raster) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Fix default format options following review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses issues #17, #18, and #22.
It also handles some new settings and begins a slight improvement in the tray icon.