Conversation
|
@davidhassell I've requested a review from you, not so much for the code, but the functionality on inux. Can you please check the export options work for you, and the metadata toggling (via the little back arrow in the selection box), and that you don't get edge artifacts (black space around the sides or top/bottom of the plot as things resize). |
|
Argh. Hold on. Something has gone wrong in the various merging. |
There was a problem hiding this comment.
Pull request overview
This PR addresses several GUI “wishlist” items (issue #25) by improving export workflows (plot/data/code), adding a hide/show control for the field-details panel, and refining plot/window aspect handling.
Changes:
- Add “Export” controls supporting Plot/Data/Code/All, including worker-side “save selected data” support.
- Add a toggle button to hide/show the selection-info (field details) panel above the plot.
- Update contour plot saving to use embedded rendering consistently and save via matplotlib when a filename is provided.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| xconv2/xconv_cf_interface.py | Adds save_selected_field_data and adjusts contour rendering/saving behavior. |
| xconv2/ui/settings_store.py | Persists last_save_data_dir for data export defaults. |
| xconv2/ui/selection_controller.py | Updates plot summary text and enables/disables plot/options/export controls. |
| xconv2/ui/plot_view_controller.py | Replaces separate save buttons with export mode selector + Export button; adds aspect/resize helpers. |
| xconv2/main_window.py | Extends plot-task requests to support data-only save and save-all flows. |
| xconv2/core_window.py | Adds selection-info panel toggle button and hooks for new export actions. |
| xconv2/cf_templates.py | Extends generated worker code to optionally save selected data; adds data-only template. |
| tests/test_coordinate_flow.py | Adds coverage for selection-info visibility toggle + window width computation helper. |
| tests/test_contour.py | Updates expectations for contour saving and adds tests for data-save code generation. |
| tests/test_cf_interface.py | Adds tests for save_selected_field_data and updated contour save behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
|
Ok, now it's good to go. |
This pull request mainly addresses minor issues outlined in #25. It has cleaned up exporting plots, data, code, from xconv2, and made minor improvements to metadata display, and plot aspect ratios.