Skip to content

Completed test_au_medicare test case - #44

Open
mamuducole wants to merge 8 commits into
mainfrom
17-detect-au_medicare
Open

Completed test_au_medicare test case#44
mamuducole wants to merge 8 commits into
mainfrom
17-detect-au_medicare

Conversation

@mamuducole

Copy link
Copy Markdown

test_au_medicare positive and negative tests completed

@mamuducole mamuducole linked an issue Oct 16, 2025 that may be closed by this pull request
@mamuducole
mamuducole requested a review from claesmk October 16, 2025 07:50
@mamuducole mamuducole self-assigned this Oct 16, 2025
@mamuducole mamuducole added this to the Sprint-2 milestone Oct 16, 2025

@claesmk claesmk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will require some analysis to determine why the test is failing

@mamuducole mamuducole left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completed test_au_medicare with no errors and all tests passed.

@claesmk claesmk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't working correctly. AU_MEDICARE is much more complicated than simple pattern matching. It uses a modulus 10 checksum described here

For example 2123 45670 1 is a valid number but 2123 25870 1 is not

Update Changes after TA review
@mamuducole
mamuducole requested a review from KanyliaR October 21, 2025 20:58

@claesmk claesmk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed some problems with valid and invalid numbers

@claesmk

claesmk commented Oct 22, 2025

Copy link
Copy Markdown
Contributor

@mamuducole you just need one more review and you'll be able to merge this PR

@KanyliaR KanyliaR left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DETECT AU_MEDICARE

3 participants