Skip to content

Show content-link in toolbar in image caption field #2992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 23, 2025
Merged

Show content-link in toolbar in image caption field #2992

merged 7 commits into from
May 23, 2025

Conversation

amatho
Copy link
Contributor

@amatho amatho commented Apr 28, 2025

Fixes NDLANO/Issues#4336

@amatho amatho changed the title Show content-link in toolbar in image caption Show content-link in toolbar in image caption field Apr 28, 2025
@amatho
Copy link
Contributor Author

amatho commented Apr 28, 2025

Vet ikke om jeg er fornøyd med denne måten for å utvide toolbarOptions og toolbarAreaFilters i InlineField, kom gjerne med innspill

@amatho amatho marked this pull request as draft April 28, 2025 10:28
@amatho
Copy link
Contributor Author

amatho commented Apr 28, 2025

Funker visst ikke siden det blir dialog inni dialog 🤡 Skal se om jeg får fiksa det

@amatho amatho marked this pull request as ready for review May 5, 2025 11:17
@amatho amatho requested a review from a team May 5, 2025 11:17
@Jonas-C
Copy link
Contributor

Jonas-C commented May 6, 2025

Kan denne forenkles en del dersom man bare kjører en merge på toolbarOptions og det som defineres inline i filen?

@amatho
Copy link
Contributor Author

amatho commented May 7, 2025 •
edited
Loading

Kan denne forenkles en del dersom man bare kjører en merge på toolbarOptions og det som defineres inline i filen?

Pusha opp et forslag nu

@gunnarvelle
Copy link
Member

Funker på et vis, men om du setter inn lenke i caption så lagres caption wrappa i en p-tag som gjør at lenka ikkje vises i forhåndsvisning og sikkert ikkje i frontend. Om eg fjerner p-taggen i html-editoren så funker det som forventa. Kan vi forhindre at caption blir p? Testa å bytte ut p med span men det hjalp ikkje.

gunnarvelle
gunnarvelle approved these changes May 23, 2025
View reviewed changes
Copy link
Member

@gunnarvelle gunnarvelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@amatho amatho merged commit 2250353 into master May 23, 2025
4 checks passed
@amatho amatho deleted the feat/image-caption-link-plugin branch May 23, 2025 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gunnarvelle gunnarvelle gunnarvelle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amatho @Jonas-C @gunnarvelle