Skip to content

Add dialog for editing AI prompts #3021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
May 23, 2025
Merged

Add dialog for editing AI prompts #3021

merged 12 commits into from
May 23, 2025

Conversation

amatho
Copy link
Contributor

@amatho amatho commented May 16, 2025

Fixes NDLANO/Issues#4345

@amatho amatho requested a review from a team May 16, 2025 08:33
@gunnarvelle
Copy link
Member

Det hadde vore en fordel å prepopulere prompt-skjema med eksisterende verdier!

@amatho
Copy link
Contributor Author

amatho commented May 16, 2025

Det hadde vore en fordel å prepopulere prompt-skjema med eksisterende verdier!

Enig!

@amatho amatho requested a review from a team May 19, 2025 07:57
@amatho amatho requested a review from Jonas-C May 20, 2025 07:57
@@ -187,6 +187,21 @@ const aiMiddleware = (req: Request, res: express.Response, next: express.NextFun
}
};

router.get("/default-ai-prompts", jwtMiddleware, aiMiddleware, async (req, res) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Burde vi sjekke at vi støtter språkkoden?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ja det gjøres inni getDefaultPrompts

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Men kanskje returnere bad request i stedet for å fallback'e til NB?

@amatho amatho force-pushed the feat/ai-edit-prompt branch from 10f656f to e2562e5 Compare May 22, 2025 11:22
@amatho amatho merged commit 1e38213 into master May 23, 2025
4 checks passed
@amatho amatho deleted the feat/ai-edit-prompt branch May 23, 2025 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants