Course Student List in Course Info Page (dart 2)#227
Merged
Conversation
* add CourseStudent class * add IPlusGetStudentList task * add getCourseStudent method * add CourseDepartmentMap task * add getDepartmentMap methods * add student list ui * update message * modify: read year/semester from courseInfo * implement student list * fix courseStudent name/id misplaced error
James-Lu-none
changed the title
James-Lu-none
requested review from
Xanonymous-GitHub,
c1ydehhx,
rileychh and
umeow0716
c1ydehhx
requested changes
Feb 23, 2024
Collaborator
c1ydehhx
left a comment
c1ydehhx
left a comment
There was a problem hiding this comment.
The student list should order by student ID.
c1ydehhx
approved these changes
Feb 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add CourseStudent class
add IPlusGetStudentList task
add getCourseStudent method
add CourseDepartmentMap task
add getDepartmentMap methods
add student list ui
update message
modify: read year/semester from courseInfo
implement student list
fix courseStudent name/id misplaced error
Description
This pr extracts course student list feature from pr #223 without any migration.