Skip to content

Rework caching #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Rework caching #23

merged 1 commit into from
Dec 4, 2024

Conversation

martialblog
Copy link
Member

@martialblog martialblog commented Dec 2, 2024

  • Rename indirectproxyrefresh to enablecaching, defaults to yes
  • Calculate the cache time based on the check interval

Fixes #22

- Rename indirectproxyrefresh to enablecaching, defaults to yes
- Calculate the cache time based on the check interval
@martialblog martialblog marked this pull request as ready for review December 2, 2024 16:36
@martialblog martialblog added this to the Release of Fork milestone Dec 2, 2024
@martialblog martialblog self-assigned this Dec 3, 2024
Copy link
Member

@tbauriedel tbauriedel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the approach of caching the data based on the check_interval!

@martialblog martialblog merged commit 4296549 into main Dec 4, 2024
2 checks passed
@martialblog martialblog deleted the refactor/caching branch December 4, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rework the caching behavior
2 participants