-
Notifications
You must be signed in to change notification settings - Fork 5
Change type of dashboard variables from constant to custom #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Basically same as: https://github.com/Mikesch-mp/icingaweb2-module-grafana/pull/346/files |
And #18 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I trust you have tested this.
well, I did not until now and the import fails. Sorry |
I deducted 1 from your trust pool |
that's only fair |
I just some testing with Grafana 12 and I had to change the variable type as well #70 |
@RincewindsHat I think we can merge this |
ok |
With Grafana 11.3 most of the dashboards broke, due to Grafana enforcing that constants are
actually constant ( o.O ) (ref: grafana/grafana#90635 ).
Since this was a breaking change but actually a bugfix, the dashboards in here should be
updated.
This PR changes the
type
of all dashboard variabels fromconstant
tocustom
.It should not change anything really on Grafana < 11.3 and in general just restore the
functionality on >= 11.3