Collection chapter backend fix#666
Open
nguyen-katie wants to merge 7 commits into
Open
Conversation
✅ Deploy Preview for dailp ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
nole2701
reviewed
Apr 22, 2026
| ...(collectionSections ?? []), | ||
| ...(collectionPageChapters?.map((ch) => ch.title) ?? []), | ||
| ].map((item) => ( | ||
| <option key={item} value={item}> |
Collaborator
There was a problem hiding this comment.
Would there be a way to distinguish between sections and chapter titles that have the same name when in the menu dropdown?
nole2701
reviewed
Apr 22, 2026
Collaborator
nole2701
left a comment
nole2701
left a comment
There was a problem hiding this comment.
Looks good just that one nitpick about duplicate names that might happen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the CollectionChapter struct in which it differentiates between a page and a document. I updated the schema and the frontend now shows the correct chapters in the table of contents that can be published under. However, there is still no backend method for collections publishing yet that works similar to MenuUpdate, so the feature for collections is unfinished until then. I added to the alert for when someone wishes to change the location of a page in a collections that says the publishing feature is still in development, but I am happy to comment out the code again to cover up the feature for collections entirely.