Added free keyword text area#694
Open
SonAndrea wants to merge 2 commits into
Open
Conversation
✅ Deploy Preview for dailp ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
alisony755
previously approved these changes
Apr 28, 2026
Collaborator
alisony755
left a comment
alisony755
left a comment
There was a problem hiding this comment.
This looks good and works well! I like the option to add either an existing keyword or a custom one.
| onRemove?: (index: number) => void | ||
| addButtonLabel: string | ||
| customForm?: React.ReactNode | ||
| children?: React.ReactNode |
Collaborator
There was a problem hiding this comment.
It might be helpful to be slightly more clear about the purpose of children, either with a comment or renaming it to something like freeInput.
Collaborator
There was a problem hiding this comment.
Or additionalForm like you use for subject headings
alisony755
dismissed
their stale review
I'm not sure if they're supposed to, but the keyword changes (as well as the changes to the other metadata fields) don't persist after the modal is submitted?
alisony755
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows for users to input a maximum of 40 characters for a keyword when editing meta data. Additionally, kept the selector for preexisting keywords for easy of use.