Skip to content

698 - Audio not showing to Editors #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nole2701 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

698 - Audio not showing to Editors #747

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d93df74
trying this fix before local migration can work to test
nole2701 Apr 21, 2026
507a76e
finished testing
nole2701 Apr 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions ...0985ed41a9eeafddbd84887555305ca49cb3.json → ...6aeac8594ab5ee5e415fffb8bb2185bce714.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

142 changes: 142 additions & 0 deletions types/.sqlx/query-b65e199479fbd23d8bdc2169e90a581faf595b9b33d274b97c2a7e88bdc9458f.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

136 changes: 0 additions & 136 deletions types/.sqlx/query-f2c4999389ca455e12e0349afcfab508671042d19332a39a3bad8d85b688f65b.json
View file
Open in desktop

This file was deleted.

1 change: 1 addition & 0 deletions types/queries/many_documents.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ select
d.format_id,
d.genre_id,
d.audio_slice_id,
d.include_audio_in_edited_collection,
media_resource.url as "audio_url?",
media_resource.recorded_at as "recorded_at?",
dailp_user.id as "recorded_by?",
Expand Down
1 change: 1 addition & 0 deletions types/queries/many_documents_by_name.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ select
d.is_reference,
d.written_at,
d.audio_slice_id,
d.include_audio_in_edited_collection,
media_resource.url as "audio_url?",
media_resource.recorded_at as "recorded_at?",
dailp_user.id as "recorded_by?",
Expand Down
5 changes: 2 additions & 3 deletions types/src/database_sql.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2744,7 +2744,7 @@ impl Loader<DocumentId> for Database {
parent_track: None,
annotations: None,
index: 0,
include_in_edited_collection: true,
include_in_edited_collection: item.include_audio_in_edited_collection,
edited_by: None,
recorded_at: item.recorded_at.map(Date::new),
recorded_by: item.recorded_by.and_then(|user_id| {
Expand Down Expand Up @@ -2821,8 +2821,7 @@ impl Loader<DocumentShortName> for Database {
parent_track: None,
annotations: None,
index: 0,
// TODO: is this a bad default?
include_in_edited_collection: true,
include_in_edited_collection: item.include_audio_in_edited_collection,
Copy link
Copy Markdown
Collaborator

@sarahkelley42 sarahkelley42 May 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming this is only impacting reads. Is the value for include_audio_in_edited_collection already set for everything in the database, or does this require migration/data entry?

Copy link
Copy Markdown
Collaborator Author

@nole2701 nole2701 May 20, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It defaults to true.

image

edited_by: None,
recorded_at: item.recorded_at.map(Date::new),
recorded_by: item.recorded_by.and_then(|user_id| {
Expand Down
Loading
Loading