fix: DeployVault, updated Vault and Factory contracts#15
Open
apoorvlathey wants to merge 1 commit intomasterfrom
Open
fix: DeployVault, updated Vault and Factory contracts#15apoorvlathey wants to merge 1 commit intomasterfrom
apoorvlathey wants to merge 1 commit intomasterfrom
Conversation
tomwade
reviewed
Oct 2, 2025
Collaborator
tomwade
left a comment
There was a problem hiding this comment.
Tests seem solid, so if they are passing my comments are probably moot. As I'm new to the codebase though, just asked 2 questions 👍
tomwade
approved these changes
Oct 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
After an upgrade to the Vault implementation, new deploys for the vaults started reverting. The issue was that during vault initialization, within the
onlyPrivilegedcheck, ifmanagerwas not set yet then themsg.sender(in this case the VaultFactory) was checked against theownerwhich is thevaultFactory.owner().Fix:
msg.senderin the vault's initialization functiontransferOwnershipcall after that has been removed as all the vaults refer to the vault factory's owner. This allows us to transfer the ownership of the vault factory once, and all the vaults automatically refer to the new owner.Tests:
Added local + forked mainnet tests which are passing successfully.