Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add @ctrl/tinycolor to dependencies #8958

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

HyperLife1119
Copy link
Collaborator

@HyperLife1119 HyperLife1119 commented Jan 6, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

@ctrl/tinycolor 是 color-picker 和 core 的依赖,但没有在 package.json 中声明,导致了 stackblitz demo 无法正常工作。

./node_modules/ng-zorro-antd/fesm2022/ng-zorro-antd-core-color.mjs:1:0-65 - 
Error: Module not found: Error: Can't resolve '@ctrl/tinycolor' in '/node_modules/ng-zorro-antd/fesm2022'

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link

zorro-bot bot commented Jan 6, 2025

This preview will be available after the AzureCI is passed.

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.91%. Comparing base (a022e48) to head (4692539).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8958   +/-   ##
=======================================
  Coverage   91.91%   91.91%           
=======================================
  Files         555      555           
  Lines       19708    19708           
  Branches     2943     2943           
=======================================
+ Hits        18114    18115    +1     
+ Misses       1268     1267    -1     
  Partials      326      326           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Laffery Laffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Laffery Laffery merged commit 1a7f759 into NG-ZORRO:master Jan 7, 2025
9 of 10 checks passed
@andrei4ik1997
Copy link

Please add this fix to version 17.4.
Thank you

@HyperLife1119
Copy link
Collaborator Author

Please add this fix to version 17.4. Thank you

For older versions, you can just install @ctrl/tinycolor manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants