fix(module:transfer): correctly set the transfer-list-body class #8960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This preview will be available after the AzureCI is passed. |
Laffery
reviewed
Jan 7, 2025
| @@ -63,10 +63,7 @@ import { NzTransferSearchComponent } from './transfer-search.component'; | |||
| <span class="ant-transfer-list-header-title">{{ titleText }}</span> | |||
| } | |||
| </div> | |||
| <div | |||
| class="{{ showSearch ? 'ant-transfer-list-body ant-transfer-list-body-with-search' : 'ant-transfer-list-body' }}" | |||
| [class]="{ 'ant-transfer__nodata': stat.shownCount === 0 }" | |||
There was a problem hiding this comment.
ant-transfer__nodata 这个 class 不用了吗
There was a problem hiding this comment.
antd 中并不存在这个 class，也没有相关样式，应该是遗留的旧名称，我想可以直接去除，WDYT？
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8960 +/- ##
=======================================
Coverage 91.91% 91.91%
=======================================
Files 555 555
Lines 19708 19708
Branches 2943 2943
=======================================
Hits 18114 18114
Misses 1268 1268
Partials 326 326 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
由于 class 未正确设置，导致样式错误。
What is the new behavior?
Does this PR introduce a breaking change?
Other information