-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(module:popover,popconfirm,tooltip): overlayClassName supports space delimited classes #8972
feat(module:popover,popconfirm,tooltip): overlayClassName supports space delimited classes #8972
Conversation
…ace delimited classes string
This preview will be available after the AzureCI is passed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8972 +/- ##
=======================================
Coverage 91.91% 91.91%
=======================================
Files 555 555
Lines 19708 19713 +5
Branches 2944 2945 +1
=======================================
+ Hits 18114 18119 +5
Misses 1267 1267
Partials 327 327 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hey friends, when are you going to release this? We're kind of blocked because of this. |
@lppedd But that's for a minor release, isn't it? |
cc @Laffery |
i'm also very much dependent on it. our angular 19 upgrade is blocked by this. would be great if this could be released asap. |
…ace delimited classes string
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: close #8952
overlayClassName only supports a single class
What is the new behavior?
nzPopconfirmOverlayClassName
nzTooltipPopoverOverlayClassName
nzPopoverOverlayClassName
support space delimited classesDoes this PR introduce a breaking change?
Other information