Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:popover,popconfirm,tooltip): overlayClassName supports space delimited classes #8972

Conversation

Laffery
Copy link
Collaborator

@Laffery Laffery commented Jan 17, 2025

…ace delimited classes string

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: close #8952

overlayClassName only supports a single class

// works
nzPopoverOverlayClassName="testClass"

// doesn't work
nzPopoverOverlayClassName="testClass1 testClass2"

What is the new behavior?

nzPopconfirmOverlayClassName nzTooltipPopoverOverlayClassName nzPopoverOverlayClassName support space delimited classes

// works
nzPopoverOverlayClassName="testClass"

// works too
nzPopoverOverlayClassName="testClass1 testClass2"

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@Laffery Laffery requested a review from simplejason as a code owner January 17, 2025 02:52
Copy link

zorro-bot bot commented Jan 17, 2025

This preview will be available after the AzureCI is passed.

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.91%. Comparing base (f1d8d92) to head (960f714).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8972   +/-   ##
=======================================
  Coverage   91.91%   91.91%           
=======================================
  Files         555      555           
  Lines       19708    19713    +5     
  Branches     2944     2945    +1     
=======================================
+ Hits        18114    18119    +5     
  Misses       1267     1267           
  Partials      327      327           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@HyperLife1119 HyperLife1119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HyperLife1119 HyperLife1119 merged commit 3fcec91 into NG-ZORRO:master Jan 17, 2025
9 of 10 checks passed
@behdi
Copy link
Contributor

behdi commented Feb 3, 2025

Hey friends, when are you going to release this? We're kind of blocked because of this.

@HyperLife1119 @simplejason

@lppedd
Copy link
Contributor

lppedd commented Feb 3, 2025

@behdi you can see an estimate date in the milestone to which the issue is assigned to.

@behdi
Copy link
Contributor

behdi commented Feb 3, 2025

@lppedd But that's for a minor release, isn't it?
This particular PR looks more like something you can put into a patch, esp. given that the current version of ng-zorro-antd has broken behavior for overlayCkassName; something that used to work in v18, is no longer working on v19, which sounds like a patch to me tbh,

@HyperLife1119
Copy link
Collaborator

cc @Laffery

@nicolaric-akenza
Copy link

i'm also very much dependent on it. our angular 19 upgrade is blocked by this. would be great if this could be released asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple classname string not working on nzPopoverOverlayClassName since ngZorroAntd 19
5 participants