Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:input-number,checkbox): accept the disabled change from ng control #8979

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

HyperLife1119
Copy link
Collaborator

@HyperLife1119 HyperLife1119 commented Jan 20, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link

zorro-bot bot commented Jan 20, 2025

This preview will be available after the AzureCI is passed.

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.92%. Comparing base (a022e48) to head (9fc9928).
Report is 13 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8979      +/-   ##
==========================================
+ Coverage   91.91%   91.92%   +0.01%     
==========================================
  Files         555      555              
  Lines       19708    19711       +3     
  Branches     2943     2945       +2     
==========================================
+ Hits        18114    18119       +5     
+ Misses       1268     1265       -3     
- Partials      326      327       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Laffery Laffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Laffery
Copy link
Collaborator

Laffery commented Jan 20, 2025

checkbox-group 应该也有同样的问题,请一起修复下
image

@HyperLife1119 HyperLife1119 changed the title fix(module:input-number): accept the disabled change from ng control fix(module:input-number,checkbox): accept the disabled change from ng control Jan 20, 2025
Copy link
Collaborator

@Laffery Laffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Laffery Laffery closed this Jan 21, 2025
@Laffery Laffery reopened this Jan 21, 2025
@Laffery Laffery merged commit 2d8968d into NG-ZORRO:master Jan 21, 2025
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[nz-input-number] New input-number does not respect disabled state on init
2 participants