feat(module:message,notification): display nzData when content is a template #9001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This preview will be available after the AzureCI is passed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9001 +/- ##
==========================================
+ Coverage 91.93% 91.94% +0.01%
==========================================
Files 555 555
Lines 19708 19708
Branches 2946 2945 -1
==========================================
+ Hits 18118 18120 +2
+ Misses 1263 1262 -1
+ Partials 327 326 -1 ☔ View full report in Codecov by Sentry. |
HyperLife1119
requested changes
Feb 10, 2025
Nicoss54
force-pushed
the
feature/nz-data-notification
branch
from
c45f48a to
ac73b65
Compare
HyperLife1119
requested changes
Feb 11, 2025
|
@HyperLife1119 all seems done :) |
HyperLife1119
changed the title
HyperLife1119
requested changes
Feb 14, 2025
Nicoss54
force-pushed
the
feature/nz-data-notification
branch
from
8f7001a to
828c6d3
Compare
Nicoss54
force-pushed
the
feature/nz-data-notification
branch
2 times, most recently
from
6bcf365 to
d1db34f
Compare
Laffery
reviewed
Feb 19, 2025
Nicoss54
force-pushed
the
feature/nz-data-notification
branch
from
e06201a to
26b0d31
Compare
|
@Laffery your comments is taken into consideration and it's implemented |
|
close #8997 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
nzData are not passed when content is custom template
Issue Number: #8997
What is the new behavior?
nzData are passed when content is custom template
Does this PR introduce a breaking change?
Other information