-
Notifications
You must be signed in to change notification settings - Fork 4k
refactor(module:pageheader): insure compatibility RxJs 6 #9052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(module:pageheader): insure compatibility RxJs 6 #9052
Conversation
This preview will be available after the AzureCI is passed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9052 +/- ##
=======================================
Coverage 91.94% 91.94%
=======================================
Files 559 559
Lines 19773 19773
Branches 3050 3050
=======================================
Hits 18181 18181
Misses 1267 1267
Partials 325 325 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
6ff9127
to
49dc100
Compare
f24f7a3
to
e2588a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
paheHeader use observed getter insteadr observers which is not compatible with RxJs 6 still suppoprt by Angular core
Issue Number: N/A
What is the new behavior?
pagheHeader usethe oberservers property
Does this PR introduce a breaking change?
Other information