fix(module:tree): read initial state of nzNodes#9380
Open
rajniszp wants to merge 3 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9380 +/- ##
==========================================
- Coverage 92.27% 90.21% -2.07%
==========================================
Files 560 573 +13
Lines 19708 23711 +4003
Branches 3025 4791 +1766
==========================================
+ Hits 18185 21390 +3205
- Misses 1191 1503 +312
- Partials 332 818 +486 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
read state recursively (including all descendant nodes)
Nicoss54
requested changes
Sep 3, 2025
Nicoss54
left a comment
Collaborator
There was a problem hiding this comment.
Could you had some test please
getting half-checked nodes from checked nodes, setting matchedNodeList not needed (no "matched" in NzTreeNodeOptions); added tests
Author
|
Added tests analogous to existing ones |
Author
|
Hi, any chance to merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Node state (
isExpanded,isSelected,isChecked,isHalfChecked,isMatched) is ignored when updating nodes/loading childrenIssue Number: N/A
What is the new behavior?
Node state is correctly set and thus represented on the UI
Does this PR introduce a breaking change?
Other information