fix(module:splitter): ensure panels sum to 100% after resize - #9429
Open
keke521jie wants to merge 1 commit into
Open
fix(module:splitter): ensure panels sum to 100% after resize#9429keke521jie wants to merge 1 commit into
keke521jie wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9429 +/- ##
==========================================
- Coverage 92.12% 91.39% -0.74%
==========================================
Files 561 561
Lines 19631 19738 +107
Branches 3107 3033 -74
==========================================
- Hits 18086 18039 -47
- Misses 1206 1371 +165
+ Partials 339 328 -11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Laffery
reviewed
Sep 26, 2025
| pxSizes[nextIndex] -= mergedOffset; | ||
| this.innerSizes.set(pxSizes); | ||
|
|
||
| const percentageSizes = pxSizes.map(size => size / containerSize); |
Collaborator
There was a problem hiding this comment.
这个改动是出于什么？按照当前设计，innerSizes 是保存实际像素大小的
/**
* Derived from defaultSize of each panel.
* After that it will be updated by the resize event with **real** size in pixels.
*/
Contributor
Author
There was a problem hiding this comment.
现在的实现在拖动调整大小后手动缩小放大屏幕会出现
这种情况。innerSizes的像素值没有计算对导致sizes百分比计算错误
所以改成了百分比计算
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Issue Number: close #9276
Does this PR introduce a breaking change?
Other information