-
Notifications
You must be signed in to change notification settings - Fork 4k
fix(module:steps): keep description below line when nzTitle is not set #9681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
claytonlin1110
wants to merge
9
commits into
NG-ZORRO:master
Choose a base branch
from
claytonlin1110:fix/steps-description-only
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
e994d2f
fix(module:steps): keep description below line when nzTitle is not set
claytonlin1110 c017d0d
fix(module:steps): synchronize antd6 styles with dom structure
claytonlin1110 c9017a7
fix: ant-steps-item-section layer
claytonlin1110 6f0f079
fix: wrapper style
claytonlin1110 3d52708
fix: antdv6 styles and dom structure
claytonlin1110 aa55464
fix: lint
claytonlin1110 aed3da4
fix: revert doc
claytonlin1110 721ad4f
chore: style
claytonlin1110 e10ea0f
fix: remove rail after pseudo element
claytonlin1110 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| --- | ||
| order: 7 | ||
| title: | ||
| zh-CN: 仅描述 | ||
| en-US: Description only | ||
| --- | ||
|
|
||
| ## zh-CN | ||
|
|
||
| 当不设置 `nzTitle` 时,仅展示描述。描述会固定显示在横线下方,不会与步骤条重叠。 | ||
|
|
||
| ## en-US | ||
|
|
||
| When `nzTitle` is not set, only the description is shown. The description always renders below the horizontal line and does not overlay the step bar. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| import { Component } from '@angular/core'; | ||
|
|
||
| import { NzStepsModule } from 'ng-zorro-antd/steps'; | ||
|
|
||
| @Component({ | ||
| selector: 'nz-demo-steps-description-only', | ||
| imports: [NzStepsModule], | ||
| template: ` | ||
| <nz-steps [nzCurrent]="1"> | ||
| <nz-step | ||
| nzDescription="This is a description only. The title row is reserved so the description stays below the horizontal line." | ||
| ></nz-step> | ||
| <nz-step nzTitle="In Progress" nzDescription="This step has both title and description."></nz-step> | ||
| <nz-step nzDescription="Another step with description only. No title provided."></nz-step> | ||
| </nz-steps> | ||
| ` | ||
| }) | ||
| export class NzDemoStepsDescriptionOnlyComponent {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.