Skip to content

Toy moss model #1434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 76 commits into
base: main
Choose a base branch
from
Open

Toy moss model #1434

wants to merge 76 commits into from

Conversation

@samsrabin
Copy link
Contributor

@samsrabin samsrabin commented Jul 2, 2025 •
edited
Loading

Description:

This PR adds an initial toy moss model based on @adrifoster's implementation in UVAFME. It's not yet connected to anything, but it is unit- and functional-tested.

Collaborators:

  • Close collaboration with @adrifoster
  • Discussions with others in the FATES SE meeting

Expectation of Answer Changes:

None

Checklist

All checklist items must be checked to enable merging this pull request:

Contributor

  • The in-code documentation has been updated with descriptive comments
  • The documentation has been assessed to determine if updates are necessary

Integrator

  • FATES PASS/FAIL regression tests were run
  • Evaluation of test results for answer changes was performed and results provided
  • FATES-CLM6 Code Freeze: satellite phenology regression tests are b4b

If satellite phenology regressions are not b4b, please hold merge and notify the FATES development team.

Documentation

Test Results:

CTSM (or) E3SM (specify which) test hash-tag:

CTSM (or) E3SM (specify which) baseline hash-tag:

FATES baseline hash-tag:

Test Output:

adrifoster and others added 30 commits March 19, 2025 09:29
initial commit
87fa4d4
making test class
24c0eb0
updates
c3c4a6c
@adrifoster
updates to fix bug
642fcf2
update
338c24a
@samsrabin
Add FatesMossMod with just UVAFME moss() subroutine.
4910840
@samsrabin
Break soil object into reals.
1d30d2a
@samsrabin
Delete an unused line.
2daea4c
@samsrabin
Delete unused variables in moss().
63d9333
@samsrabin
Remove moisture growth factor (drydays implementation).
a8da251
@samsrabin
Moss: Use fates_r8 reals.
5576138
@samsrabin
Moss: Rearrange parameters/variables.
eeed237
@samsrabin
Add moss unit test. Untested.
e30c9f0
@samsrabin
Moss: Add some constants.
6ba3f2d
@samsrabin
Merge branch 'testing_update' into moss
f8a8c76
@samsrabin
Add LeafBiophysicsMod.F90 to biogeophys/CMakeLists.txt.
57963bb
@samsrabin
Merge tag 'sci.1.84.0_api.40.0.0' into testing_update_ssr
c663592 
updates to the default parameter file

This update includes a phenology parameter refactor per NGEET#1355, an update
to the default exclusion parameter per NGEET#1358, updates to the logging
parameters to default to clearcut via NGEET#1359, and a minor long name
correction per NGEET#1394.
@samsrabin
Add LeafBiophysicsMod.F90 to biogeophys/CMakeLists.txt
157b2e9
@samsrabin
Fix QuadraticRootsNSWC call in FatesTestMathUtils.F90.
89320b6
@samsrabin
Merge branch 'testing_update_ssr' into moss
39e7af4
@samsrabin
Moss testing: Switch actual/expected
09fb0dd
@samsrabin
Add a temporary moss test.
3ccec5b
@samsrabin
Moss: Refactor out repro_eff.
8ea6292
@samsrabin
Moss: Add units to variable names.
74944bb
@samsrabin
Moss: Add a TODO.
a2be658
@samsrabin
Moss: Clarify that litter calculation is a flux.
db44553
@samsrabin
Moss: Further clarify variable names.
eb01a47
@samsrabin
Moss: Simplify an equation.
ea80c19
@samsrabin
Moss: Rearrange.
ca2b543
@samsrabin
Moss: Some var names now indicate before/after timestep.
abb2678
samsrabin added 18 commits July 31, 2025 16:03
@samsrabin
Add one moss functional test.
a1c8ecc
@samsrabin
Simplify plot_moss_cla_x_mossbiomass().
1596d7e
@samsrabin
Generalized to plot_dim0x_dim1legend().
9546b53
@samsrabin
Add out_algf.
16db675
@samsrabin
Add functional tests of moss_biomass_change_kg_per_m2().
73feb39
@samsrabin
Moss functional test plots now start with moss_.
4396292
@samsrabin
Moss functional tests now use native plot setup.
f7e7518
@samsrabin
Moss functional tests: Better biomass bins.
a44217e
@samsrabin
Moss light functions: Use LAI, not LAI*area.
566acfe
@samsrabin
Moss unit tests: Check litter_growth_multiplier getting ~0.5.
d90d349
@samsrabin
Update moss functional tests for LAI instead of CLA.
fc517ec
@samsrabin
Add functional test for moss decid litter multiplier.
ee18ae8
@samsrabin
Rename decLit_t_per_haplot to decid_litter.
819d0b4
@samsrabin
Moss decid litter function now uses kg/m2 instead of t/ha.
20e7782
@samsrabin
moss() subroutine now uses kg/m2 biomass, not kg/plot.
0b8266f
@samsrabin
Merge tag 'sci.1.86.3_api.40.0.0_tools.3.1.0' into moss
97f4f5b 
Testing improvements to enable ctsm system testing
@samsrabin
Fix moss functional test plots when not called alone.
4716b4e
@samsrabin
Roll back some testing stuff that never got to main.
b927ba7
@samsrabin samsrabin changed the title [WIP] Moss Toy moss model Aug 6, 2025
@samsrabin samsrabin marked this pull request as ready for review August 6, 2025 16:35
@samsrabin
Copy link
Contributor Author

samsrabin commented Aug 6, 2025

Here are the results of the functional tests at this point:
moss_plot_out_biomass_delta
moss_plot_out_mort
moss_plot_out_resp
moss_plot_out_algf
moss_plot_out_al
moss_plot_out_dlgf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@samsrabin samsrabin

Labels

None yet

Projects

FATES Pull Request Planning and Status
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@samsrabin @adrifoster