Skip to content

Conversation

@XiulinGao
Copy link
Contributor

Description:

This PR fix #1465

Collaborators:

@samsrabin

Expectation of Answer Changes:

No, only unit update in code documentation and parameter description

Checklist

If this is your first time contributing, please read the CONTRIBUTING document.

All checklist items must be checked to enable merging this pull request:

Contributor

  • The in-code documentation has been updated with descriptive comments
  • The documentation has been assessed to determine if updates are necessary

Integrator

  • FATES PASS/FAIL regression tests were run
  • Evaluation of test results for answer changes was performed and results provided
  • FATES-CLM6 Code Freeze: satellite phenology regression tests are b4b

If satellite phenology regressions are not b4b, please hold merge and notify the FATES development team.

Documentation

Test Results:

CTSM (or) E3SM (specify which) test hash-tag:

CTSM (or) E3SM (specify which) baseline hash-tag:

FATES baseline hash-tag:

Test Output:

@glemieux glemieux added the type: clean up Simple issues like typos, formatting, style guide alignment, etc. label Oct 6, 2025
@samsrabin samsrabin self-requested a review October 6, 2025 19:09
@glemieux glemieux added parameters: value change Pertaining to changes to the parameter file only (i.e. not removing or adding new parameters) inputs: parameter file Pertaining to changes to the FATES parameter file labels Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

inputs: parameter file Pertaining to changes to the FATES parameter file parameters: value change Pertaining to changes to the parameter file only (i.e. not removing or adding new parameters) type: clean up Simple issues like typos, formatting, style guide alignment, etc.

Projects

Status: Finding Reviewers

Development

Successfully merging this pull request may close these issues.

UpdateRxfireBurnWindow and update_nesterov_index() comments have wrong wind units

2 participants