GitHub CI: Initial GitHub migration commit - #8
Conversation
Note: CodeQL static code analysis is only an MVP added during migration. SonarQube has not been configured for ngen and doesn't succeed.
|
Made some changes. Couldn't get SonarQube to work. |
|
@miguelp1986 Thank you, and that looks much better. I don't think this application was ever setup to run with sonarqube pre-migration from GitLab. Similar to CodeQL, sonarqube doesn't only look at the source code for C++, it has to be built through a build wrapper. I can get it to work, but it should probably drop lower on the priority list. The CodeQL results are pretty informative as well. I think that could also be improved, as I'm building for CodeQL pretty generically rather than aiming for 1:1 to how we build in Docker, and I took the test code out of scope via the compile flag to avoid figuring out pyarrow compilation versions for the submodules. We can hopefully discuss scope with a code owner who may have specific needs or prefer that it stay as is scanning only the application code. Then, we can look to improve static code analysis across the board as a planned effort. |
GitHub CI: Initial GitHub migration commit
Note: CodeQL static code analysis is only an MVP added during migration. SonarQube has not been configured for ngen and doesn't succeed.