Skip to content

GitHub CI: Initial GitHub migration commit - #8

Merged
miguelp1986 merged 3 commits into
developmentfrom
github-ci-kevin
Aug 23, 2025
Merged

GitHub CI: Initial GitHub migration commit#8
miguelp1986 merged 3 commits into
developmentfrom
github-ci-kevin

Conversation

@kevinspurrier

Copy link
Copy Markdown

Note: CodeQL static code analysis is only an MVP added during migration. SonarQube has not been configured for ngen and doesn't succeed.

Note: CodeQL static code analysis is only an MVP added during migration. SonarQube has not been configured for ngen and doesn't succeed.
@kevinspurrier
kevinspurrier requested review from cmaynard-ngwpc and miguelp1986 and removed request for cmaynard-ngwpc August 21, 2025 22:35
@miguelp1986

Copy link
Copy Markdown
Member

Made some changes. Couldn't get SonarQube to work.

@kevinspurrier

Copy link
Copy Markdown
Author

@miguelp1986 Thank you, and that looks much better. I don't think this application was ever setup to run with sonarqube pre-migration from GitLab. Similar to CodeQL, sonarqube doesn't only look at the source code for C++, it has to be built through a build wrapper. I can get it to work, but it should probably drop lower on the priority list. The CodeQL results are pretty informative as well. I think that could also be improved, as I'm building for CodeQL pretty generically rather than aiming for 1:1 to how we build in Docker, and I took the test code out of scope via the compile flag to avoid figuring out pyarrow compilation versions for the submodules. We can hopefully discuss scope with a code owner who may have specific needs or prefer that it stay as is scanning only the application code. Then, we can look to improve static code analysis across the board as a planned effort.

@miguelp1986 miguelp1986 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pipeline working as expected. Approved.

@miguelp1986
miguelp1986 merged commit 4896236 into development Aug 23, 2025
9 of 10 checks passed
@miguelp1986
miguelp1986 deleted the github-ci-kevin branch August 23, 2025 01:05
zhengtaocui pushed a commit that referenced this pull request May 18, 2026
GitHub CI: Initial GitHub migration commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants